Minor Modifications to Trigger Automated Clang Checks

[ianna]

• Cleanup and reformatting

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22365/console Started: 2017/08/17 17:07

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/Core

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20198/184

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20198/184/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20198/184/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

[cmsbuild]

+1
Tested at: dc72be3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20198/22365/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5506301
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20198/22365/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20198/22365/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20198/22365/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2653169
• DQMHistoTests: Total failures: 234
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2652746
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[cmsbuild]

Pull request #20198 was updated. @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please check and sign again.

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22375/console Started: 2017/08/18 11:18
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22376/console Started: 2017/08/18 11:21

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20198/198

[cmsbuild]

+1
Tested at: 6f7818e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20198/22376/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
40a53de
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20198/22376/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20198/22376/git-merge-result

[cmsbuild]

Comparison job queued.

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20198/22376/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2653934
• DQMHistoTests: Total failures: 261
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2653484
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[davidlange6]

+1