Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ECAL constantTerm for PhaseII (fw port for 93) #20200

Conversation

franzoni
Copy link

FW port of: #20193

the ECAL resolution constant term needs to be fixed for the imminent re-production of samples targeting Barrel Calorimeter TDR, by amending for these two records:

     EcalIntercalibConstantsRcd 
     EcalIntercalibConstantsMCRcd

the tags _v2 (see below) which are selected via the ageing custom function.
All other ingredients of the condition-driven ageing scenarios need to stay the same.

@kpedro88 @amassiro @arunhep @lpernie @cerminar

…cd in customize, deploy fix to constant term
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @franzoni (Giovanni Franzoni) for master.

It involves the following packages:

SLHCUpgradeSimulations/Configuration

@cmsbuild, @civanch, @mdhildreth, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ebrondol, @sviret this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@franzoni
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22367/console Started: 2017/08/17 18:20

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20200/186

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20200/22367/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2653169
  • DQMHistoTests: Total failures: 211
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2652769
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

davidlange6 commented Aug 17, 2017 via email

@cmsbuild cmsbuild merged commit 40a53de into cms-sw:master Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants