-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XeXe collision era and relval workflow (92X) #20760
Conversation
A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for CMSSW_9_2_X. It involves the following packages: Configuration/Eras @perrotta, @prebello, @vazzolini, @dmitrijus, @kmaeshima, @civanch, @perrozzi, @efeyazgan, @kpedro88, @fabozzi, @cmsbuild, @GurpreetSinghChahal, @franzoni, @thuer, @slava77, @mdhildreth, @vanbesien, @govoni, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Can someone please trigger the tests? |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Pull request #20760 was updated. @ghellwig, @kpedro88, @fabozzi, @dmitrijus, @govoni, @perrotta, @vanbesien, @cmsbuild, @GurpreetSinghChahal, @davidlange6, @efeyazgan, @cerminar, @slava77, @prebello, @vazzolini, @kmaeshima, @arunhep, @perrozzi, @thuer, @monttj, @franzoni, @lpernie can you please check and sign again. |
Comparison is ready Comparison Summary:
|
Pull request #20760 was updated. @ghellwig, @kpedro88, @fabozzi, @dmitrijus, @govoni, @perrotta, @vanbesien, @cmsbuild, @GurpreetSinghChahal, @davidlange6, @efeyazgan, @cerminar, @slava77, @prebello, @vazzolini, @kmaeshima, @arunhep, @perrozzi, @thuer, @monttj, @franzoni, @lpernie can you please check and sign again. |
Pull request #20760 was updated. @ghellwig, @kpedro88, @fabozzi, @dmitrijus, @govoni, @perrotta, @vanbesien, @cmsbuild, @GurpreetSinghChahal, @davidlange6, @efeyazgan, @cerminar, @slava77, @prebello, @vazzolini, @kmaeshima, @arunhep, @perrozzi, @thuer, @monttj, @franzoni, @lpernie can you please check and sign again. |
@@ -44,5 +44,13 @@ | |||
|
|||
from Configuration.Eras.Modifier_peripheralPbPb_cff import peripheralPbPb | |||
peripheralPbPb.toModify(seedGeneratorFromRegionHitsEDProducer, | |||
doClusterCheck = True, # FIXMETOO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this doClusterCheck parameter remain inside the ClusterCheckPSet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Didn't see it as that era isn't tested in relval. As discussed with Slava we may merge or remove it soon. Should I push a fix now, or are you still reviewing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do it now,
I was comparing the 92X and 94X versions of your PR, and this is the only significant difference I spotted.
Pull request #20760 was updated. @ghellwig, @kpedro88, @fabozzi, @dmitrijus, @govoni, @perrotta, @vanbesien, @cmsbuild, @GurpreetSinghChahal, @davidlange6, @efeyazgan, @cerminar, @slava77, @prebello, @vazzolini, @kmaeshima, @arunhep, @perrozzi, @thuer, @monttj, @franzoni, @lpernie can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
merge |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Backport of #20749 20749
Customizes the pp reconstruction to keep timing in check.
To be used for XeXe data taking on October 12th.
Adds a relVal worklow to test (148)
Supersedes #20714