Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T online DQM changes for XeXe (and other HI) #20765

Merged

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Oct 6, 2017

Change the raw data inputTags for the unpackers in the L1T online DQM configuration to rawDataRepacker in case the run is a HI run.

This should prevent ProductNotFound exceptions for the XeXe run.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20765/1188

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

DQM/Integration

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@makortel, @threus, @batinkov this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

+1

dqm online only

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23631/console Started: 2017/10/10 14:23

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Tested at: 121396d

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
02d60c8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20765/23631/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20765/23631/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20765/23631/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
10024.0 step5

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step5_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
02d60c8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20765/23631/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20765/23631/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@thomreis
Copy link
Contributor Author

The logs do not indicate where the crash comes from. There have been no changes in the harvesting step where the crash happened.

@cmsbuild
Copy link
Contributor

-1

Tested at: 121396d

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dd401df
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20765/23674/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20765/23674/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20765/23674/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1000.0 step3

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step3_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dd401df
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20765/23674/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20765/23674/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@thomreis
Copy link
Contributor Author

The error has again nothing to do with the code changes. @rekovic could you launch again please?

@thomreis thomreis changed the title L1T online DQM changes for XeXe L1T online DQM changes for XeXe (and other HI) Oct 13, 2017
@rekovic
Copy link
Contributor

rekovic commented Oct 13, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23758/console Started: 2017/10/13 14:37

@rekovic
Copy link
Contributor

rekovic commented Oct 13, 2017

apparently non related errors in previous failures.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20765/23758/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2767139
  • DQMHistoTests: Total failures: 101
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2766867
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a5d80f0 into cms-sw:master Oct 26, 2017
@thomreis thomreis deleted the l1t_online_dqm_config_support_for_xexe branch October 26, 2017 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants