Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-alca100 Update IsoTrack calibration system to deal with only L1 trigger (no HLT) #20776

Merged
merged 2 commits into from
Oct 16, 2017

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Oct 6, 2017

Also takeout some unnecessary casting

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20776/1213

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Calibration/HcalCalibAlgos
Calibration/IsolatedParticles

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Oct 6, 2017

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23514/console Started: 2017/10/06 23:19

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20776/23514/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2761427
  • DQMHistoTests: Total failures: 250
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2760990
  • DQMHistoTests: Total skipped: 187
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@lpernie
Copy link
Contributor

lpernie commented Oct 10, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@bsunanda
Copy link
Contributor Author

@smuzaffar @davidlange6 @slava77 The failure is not due to this PR. Please advise

@smuzaffar
Copy link
Contributor

please test
error was in IB which is fixed now

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23714/console Started: 2017/10/12 12:38

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20776/23714/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2767051
  • DQMHistoTests: Total failures: 106
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2766774
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Oct 15, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1da1abf into cms-sw:master Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants