Clang-tidy checks for DataFormats

[davidlange6]

PR to apply clang-tidy checks to all files except those that are a part of open pull requests (as of an hour ago) and files in test directories [assuming tests are ok we'll merge this tomorrow to avoid conflicts to the extent possible]

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20789/1231

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

DataFormats/Alignment
DataFormats/BTauReco
DataFormats/CSCDigi
DataFormats/CSCRecHit
DataFormats/Candidate
DataFormats/CastorReco
DataFormats/Common
DataFormats/DTRecHit
DataFormats/DetId
DataFormats/EcalDetId
DataFormats/EcalDigi
DataFormats/EcalRecHit
DataFormats/EgammaCandidates
DataFormats/EgammaReco
DataFormats/FP420Cluster
DataFormats/FP420Digi
DataFormats/FWLite
DataFormats/GEMRecHit
DataFormats/GeometryCommonDetAlgo
DataFormats/GeometrySurface
DataFormats/GeometryVector
DataFormats/HGCRecHit
DataFormats/HLTReco
DataFormats/HcalDetId
DataFormats/HcalDigi
DataFormats/HcalIsolatedTrack
DataFormats/HeavyIonEvent
DataFormats/HepMCCandidate
DataFormats/JetReco
DataFormats/L1CSCTrackFinder
DataFormats/L1DTTrackFinder
DataFormats/L1GlobalCaloTrigger
DataFormats/L1GlobalMuonTrigger
DataFormats/L1GlobalTrigger
DataFormats/L1TCalorimeter
DataFormats/L1TGlobal
DataFormats/L1THGCal
DataFormats/L1TrackTrigger
DataFormats/L1Trigger
DataFormats/Luminosity
DataFormats/METReco
DataFormats/MuonDetId
DataFormats/MuonReco
DataFormats/MuonSeed
DataFormats/ParticleFlowCandidate
DataFormats/ParticleFlowReco
DataFormats/PatCandidates
DataFormats/Phase2TrackerDigi
DataFormats/Provenance
DataFormats/RPCDigi
DataFormats/RPCRecHit
DataFormats/RecoCandidate
DataFormats/Scalers
DataFormats/SiPixelDetId
DataFormats/SiPixelRawData
DataFormats/SiStripCommon
DataFormats/SiStripDetId
DataFormats/TauReco
DataFormats/TestObjects
DataFormats/TrackReco
DataFormats/TrackerCommon
DataFormats/TrackerRecHit2D
DataFormats/TrackingRecHit

@ghellwig, @perrozzi, @kpedro88, @Martin-Grunewald, @rekovic, @govoni, @perrotta, @civanch, @silviodonato, @cmsbuild, @fwyzard, @smuzaffar, @Dr15Jones, @mdhildreth, @cerminar, @slava77, @mommsen, @mulhearn, @efeyazgan, @arunhep, @emeschi, @thuer, @monttj, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @erikbutz, @rappoccio, @gouskos, @yslai, @felicepantaleo, @jainshilpi, @abbiendi, @TaiSakuma, @kpedro88, @argiro, @pfs, @thomreis, @ahinzmann, @threus, @varuns23, @seemasharmafnal, @mmarionncern, @kreczko, @sethzenz, @JyothsnaKomaragiri, @makortel, @acaudron, @jhgoh, @lgray, @mmusich, @jdolen, @HuguesBrun, @sviret, @ferencek, @OlivierBondu, @trocino, @yetkinyilmaz, @vandreev11, @Sam-Harper, @rovere, @VinInn, @jdamgov, @ptcox, @nhanvtran, @gkasieczka, @tocheng, @schoef, @ebrondol, @amagitte, @cseez, @mandrenguyen, @battibass, @wddgit, @calderona, @mverzett, @cbernet, @gpetruc, @imarches, @mariadalfonso, @amarini, @pvmulder, @bachtis, @jbsauvan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23520/console Started: 2017/10/07 10:46

[cmsbuild]

+1
Tested at: 908b4db
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20789/23520/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a37ee8e
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20789/23520/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20789/23520/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20789/23520/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2761427
• DQMHistoTests: Total failures: 221
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2761019
• DQMHistoTests: Total skipped: 187
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[civanch]

+1

[davidlange6]

merge