MiniAOD: use all genParticles for patJets partonFlavour #20840
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @arizzi for master. It involves the following packages: PhysicsTools/PatAlgos @perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@azzurip |
|
please test |
|
The tests are being triggered in jenkins. |
|
Hello @arizzi , Sorry, I was at a conference last week and could not reply. The fix looks fine to me. Kind regards, |
|
-1 Tested at: 35e8aa8 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_2e34v30 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --fileout file:RelVal_Raw_2e34v30_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Mon Oct 9 13:05:54 2017-date Mon Oct 9 13:03:54 2017 s - exit: 23552 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
the error seem unrelated to me |
|
That error is also in the IB since the merging of #20286, as far as I can understand. |
|
@arizzi Yes, this is what we agreed on. |
|
Comparison is ready Comparison Summary:
|
|
@ahinzmann, yes, b tagging should not be broken since the primary flavor definition is hadron-based so not affected by any changes to the parton-based flavor. @arizzi, I think |
|
@ferencek this PR is meant to be minimal because 94X is closing, I would
not touch anything just for cleanup before this is merged.
…On Mon, Oct 9, 2017 at 5:45 PM, Dinko Ferencek ***@***.***> wrote:
@ahinzmann <https://github.com/ahinzmann>, yes, b tagging should not be
broken since the primary flavor definition is hadron-based so not affected
by any changes to the parton-based flavor.
@arizzi <https://github.com/arizzi>, I think task.add(process.
selectedHadronsAndPartons) in miniAOD_tools.py can also be removed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20840 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEyilkM77yEu2Vocwbe_jhNIz6jwCAOSks5sqj-LgaJpZM4PyL_C>
.
|
|
@arizzi, fair enough. |
|
@ahinzmann |
|
should we retrigger the test (i.e. was the IB fixed?) |
|
please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
comparison-pending
tests-pending
tests-started
and removed
comparison-available
tests-rejected
tests-pending
labels
|
Net effect (from low stat jenkins tests, wf 10024): move a few jets away from jetflavour=0, and reshuffle a bit the other flavours (here an electron jet becomes a jet from photon): |
|
I think what we see is a few more gluon jets instead of flavour = 0 and
one "d" becoming a gluon.
this is expected I'd say.
…On Tue, Oct 10, 2017 at 6:11 PM, perrotta ***@***.***> wrote:
Net effect (from low stat jenkins tests, wf 10024): move a few jets away
from jetflavour=0, and reshuffle a bit the other flavours (here an electron
jet becomes a jet from photon):
[image: jetmet__jetvalidation_slimmedjets_partonflavor]
<https://user-images.githubusercontent.com/4069749/31397355-11d44dea-ade6-11e7-9a25-c6fde8ab7ef1.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20840 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEyilvIlvvn6Mqyp169jLTIXe3geq4XDks5sq5cwgaJpZM4PyL_C>
.
|
|
Indeed: biased by pdgId :-)
ar1izzi <notifications@github.com> ha scritto:
… I think what we see is a few more gluon jets instead of flavour = 0 and
one "d" becoming a gluon.
this is expected I'd say.
On Tue, Oct 10, 2017 at 6:11 PM, perrotta ***@***.***> wrote:
> Net effect (from low stat jenkins tests, wf 10024): move a few jets away
> from jetflavour=0, and reshuffle a bit the other flavours (here an electron
> jet becomes a jet from photon):
> [image: jetmet__jetvalidation_slimmedjets_partonflavor]
> <https://user-images.githubusercontent.com/4069749/31397355-11d44dea-ade6-11e7-9a25-c6fde8ab7ef1.png>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#20840 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AEyilvIlvvn6Mqyp169jLTIXe3geq4XDks5sq5cwgaJpZM4PyL_C>
> .
>
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#20840 (comment)
|
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
|
merge |
This should implement Jet flavour in MiniAOD as agreed in the pat (i.e. use all genparticles for flavour stored by value)
@Andrej-CMS @gpetruc @ahinzmann @amarini @ferencek