Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation warnings (ClassDef macro) #20842

Merged
merged 1 commit into from Oct 9, 2017

Conversation

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20842/1285

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2017

A new Pull Request was created by @mrodozov for master.

It involves the following packages:

Calibration/HcalCalibAlgos
IOPool/TFileAdaptor

@ghellwig, @smuzaffar, @Dr15Jones, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @wddgit, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Oct 9, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23588/console Started: 2017/10/09 12:20

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2017

-1

Tested at: 6069b13

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b3b7d36
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20842/23588/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20842/23588/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20842/23588/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_2e34v22 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --fileout file:RelVal_Raw_2e34v22_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Mon Oct 9 14:07:14 2017-date Mon Oct 9 14:02:22 2017 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02493/slc6_amd64_gcc630/cms/cmssw/CMSSW_9_4_X_2017-10-08-2300/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v22.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Mon Oct 9 14:07:14 2017-date Mon Oct 9 14:02:22 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:2e34v22,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2e34v22 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v22_DATA.root --fileout file:RelVal_Raw_2e34v22_DATA_HLT_RECO.root : FAILED - time: date Mon Oct 9 14:07:14 2017-date Mon Oct 9 14:02:22 2017 s - exit: 21504

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b3b7d36
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20842/23588/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20842/23588/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20842/23588/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2764467
  • DQMHistoTests: Total failures: 108
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2764188
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 97c6883 into cms-sw:master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants