New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang-tidy checks for FastSimDataFormats #20852
Clang-tidy checks for FastSimDataFormats #20852
Conversation
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: FastSimDataFormats/L1GlobalMuonTrigger @cmsbuild, @ssekmen, @civanch, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
merge
On 9 Oct 2017, at 21:29, cmsbuild <notifications@github.com<mailto:notifications@github.com>> wrote:
Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20852/23598/summary.html
There are some workflows for which there are errors in the baseline:
11624.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request
Comparison Summary:
* No significant changes to the logs found
* Reco comparison results: 0 differences found in the comparisons
* DQMHistoTests: Total files compared: 26
* DQMHistoTests: Total histograms compared: 2632155
* DQMHistoTests: Total failures: 89
* DQMHistoTests: Total nulls: 0
* DQMHistoTests: Total successes: 2631897
* DQMHistoTests: Total skipped: 169
* DQMHistoTests: Total Missing objects: 0
* Checked 107 log files, 10 edm output root files, 26 DQM output files
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#20852 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzywxKg_3etP3nT7XXmgUYcQa6mSKe1ks5sqnQLgaJpZM4PyaNe>.
|
PR to apply clang-tidy checks to all files except those that are a part of open pull requests (as of an hour ago) and files in test directories [assuming tests are ok we'll merge this quickly to avoid conflicts to the extent possible]