-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build errors and comp warnings in L1Trigger/L1TMuonEndCap #20857
Fix build errors and comp warnings in L1Trigger/L1TMuonEndCap #20857
Conversation
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @mrodozov for master. It involves the following packages: L1Trigger/L1TMuonEndCap @cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
merge |
@@ -40,7 +41,7 @@ class LeastSquares : public LossFunction | |||
{ | |||
public: | |||
LeastSquares(){} | |||
~LeastSquares(){} | |||
virtual ~LeastSquares(){} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be marked as override
Fixes build errors and compilation warnings for gcc7 IBs listed here:
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_9_4_X_2017-10-09-1100/L1Trigger/L1TMuonEndCap