adding good e/gamma flag to PackedCandidate for MiniAOD #20903
Conversation
|
code-checks |
|
8 hours now, looks like its stuck |
|
code-checks |
|
code-checks
… On Oct 12, 2017, at 9:37 AM, Sam-Harper ***@***.***> wrote:
8 hours now, looks like its stuck
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@smuzaffar - could you have a look at this PR? |
|
just a bad luck with this PR. cmsbot updated the message that code-checks are running but then jenkins job failed https://cmssdt.cern.ch/jenkins/job/cms-bot/373333/console (which means code-checks projects was not triggered) and after that bot assumes that checks are already running. I will update a timeout of 60mins after that cmsbot should re-trigger the checks. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @Sam-Harper for master. It involves the following packages: DataFormats/PatCandidates @perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
Sam-Harper
changed the title
|
-1 Tested at: 1861b3b The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step5_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
|
-1 Tested at: 1861b3b The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step5_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
Annoying... @davidlange6 @smuzaffar : is anything we can do to get rid of those spurios step5 errors which are flooding the tests in these days? Thanks |
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
So I'm fully happy with this change. My unit test implies that I'm not clobbering anything else and that I can read/write it back correctly. And then I've now done a test on 5K DoublePhoton gun events to ensure that the bit is properly been set in the PackedCandidate producer. I would really like this in if possible, it will really help out our understanding of the regression corrections going into particle flow. Thanks. |
|
merge |
Dear All,
This sets a flag in PackedCandidate to indicate whether candidate is a good e/gamma object or not. Here good means "gets E/gamma energy regresssions". All electrons are automatically good, the problem is for photons, theres no way at the miniAOD level to know if you should apply the regression to it or not short of trying to do a tight p4 match with the original photon which is error prone.
This small change will greatly help E/gamma and JetMET understand the effects of the regression on jets + met as well as making it a lot easier to apply new energy corrections. Given the ongoing issues with E/gamma energy regression corrections, its extremely useful to have a clean way to re apply them at the miniAOD level.
As an aside, had this feature already been here, the regression PR would have already gone though as my bug was in trying to apply the regression on miniAOD packed candidates.
I've already cleared this with XPOG.
I have one more minor check to do in the morning