Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix binning in muon->innerTrack DQM [backport #20970] #20971

Merged
merged 5 commits into from
Oct 27, 2017

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Oct 19, 2017

backport of #20970

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2017

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_9_2_X.

It involves the following packages:

DQM/TrackingMonitor

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @fioriNTU, @idebruyn, @ebrondol, @threus this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@mtosi
Copy link
Contributor Author

mtosi commented Oct 19, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23874/console Started: 2017/10/19 13:15

@mtosi
Copy link
Contributor Author

mtosi commented Oct 19, 2017

@VinInn
once tier0 uses this PR
the hit efficiency vs PU plots for the muon->innerTrack
will have a different binning (40, 0.5, 120.5) w.r.t. the current one (50, 0.5, 50.5)

@cmsbuild
Copy link
Contributor

-1

Tested at: 3779f73

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5b5452e
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20971/23874/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20971/23874/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20971/23874/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found an error when building:

gmake[1]: Target 'PostBuild' not remade because of errors.
gmake[1]: Leaving directory '/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-10-17-2300'
config/SCRAM/GMake/Makefile.rules:2088: recipe for target 'src' failed
gmake: *** [src] Error 2
gmake: Target 'all' not remade because of errors.
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5b5452e
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20971/23874/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20971/23874/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@mtosi
Copy link
Contributor Author

mtosi commented Oct 19, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23876/console Started: 2017/10/19 14:05

@cmsbuild
Copy link
Contributor

Pull request #20971 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #20971 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

@mtosi
Copy link
Contributor Author

mtosi commented Oct 19, 2017 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23879/console Started: 2017/10/19 15:49

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20971/23879/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1982671
  • DQMHistoTests: Total failures: 29704
  • DQMHistoTests: Total nulls: 906
  • DQMHistoTests: Total successes: 1951889
  • DQMHistoTests: Total skipped: 172
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 9 edm output root files, 23 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f5ad591 into cms-sw:CMSSW_9_2_X Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants