-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Geant4 exception handling #21113
Conversation
The code-checks are being triggered in jenkins. |
please test |
+code-checks |
The tests are being triggered in jenkins. |
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages: SimG4Core/Application @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Hi @davidlange6, likely this fix should be back-ported to 9_4_X and 9_3_X? |
Enable CMS exception handler (derived from G4VException) for handling of exceptions from Geant4. Forward any Geant4 exception to the CMS framework as fatal exception or as a warning.
Clean-up produce method of OscarProducer and OscarMTProducer.
Should not affect results of any WF.