Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Geant4 exception handling #21113

Merged
merged 2 commits into from
Nov 1, 2017
Merged

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Nov 1, 2017

Enable CMS exception handler (derived from G4VException) for handling of exceptions from Geant4. Forward any Geant4 exception to the CMS framework as fatal exception or as a warning.

Clean-up produce method of OscarProducer and OscarMTProducer.

Should not affect results of any WF.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

The code-checks are being triggered in jenkins.

@civanch
Copy link
Contributor Author

civanch commented Nov 1, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21113/1742

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24099/console Started: 2017/11/01 12:00

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/Application

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21113/24099/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2838442
  • DQMHistoTests: Total failures: 116
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2838155
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@civanch
Copy link
Contributor Author

civanch commented Nov 1, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 76533ea into cms-sw:master Nov 1, 2017
@civanch
Copy link
Contributor Author

civanch commented Nov 1, 2017

Hi @davidlange6, likely this fix should be back-ported to 9_4_X and 9_3_X?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants