Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coordinate printout to SiPixelBadModuleReader #21123

Merged
merged 1 commit into from Nov 2, 2017

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Nov 1, 2017

I found the module coordinates useful when studying the contents of SiPixelQuality with SiPixelBadModuleReader, so thought to contribute them back.

Tested in 9_4_0_pre3, no changes expected in standard workflows.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21123/1752

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

CondTools/SiPixel

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Nov 1, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24110/console Started: 2017/11/01 21:45

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21123/24110/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2838442
  • DQMHistoTests: Total failures: 135
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2838136
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Nov 2, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit c22b23e into cms-sw:master Nov 2, 2017
@makortel makortel deleted the pixelBadModuleReader branch February 12, 2018 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants