Run2-TB36 Also save cumulative energy deposit for pasive volumes in the list #21125
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: SimDataFormats/CaloHit @cmsbuild, @civanch, @mdhildreth, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@bsunanda , can you, please, clarify what is the difference between hit energy and cumulative hit energy? |
|
@civanch I believe I tried to explain what it does now |
|
@bsunanda , this is strange to me, because it is difficult to imagine that a very detailed information for fine structure geometry will be needed. If by construction a separate hits are created without any accumulation then we may have large number of hits, which will take big volume. Potentially, it is possible to before creation of a new hit to check to add it to one of existing (event if they are not in the same volume but are in daughter or granddaughter). This will be a real saving of number of hits. An addition of cumulative energy will not do that. Of course, technically I have no problem with this PR. |
|
+1 |
|
+code-checks |
|
Pull request #21125 was updated. @cmsbuild, @civanch, @mdhildreth, @kpedro88 can you please check and sign again. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
|
+1 |
|
@civanch Please approve |
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Earlier it was recording the energy deposited in the leaf volume only. Now in addition it record the energy deposited in this volume as well as any volume which is a daughter, grand-daughter, ... of this volume.