GEM bugfix for issue #20772

[jshlee]

@slava77, @kpedro88, @calabria

The standalone ME0Muon is no longer needed, so i removed it from the standard reco chain.
GEMSegmentBuilder.cc has been fixed.
ME0SegAlgoRU.cc had a warning msg.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21146/1786

[cmsbuild]

A new Pull Request was created by @jshlee (Jason Lee) for master.

It involves the following packages:

RecoLocalMuon/GEMSegment
RecoMuon/Configuration

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @jhgoh, @echapon, @calderona, @HuguesBrun, @battibass, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24149/console Started: 2017/11/03 10:31

[cmsbuild]

+1
Tested at: a41a3a2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21146/24149/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e63f423
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21146/24149/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21146/24149/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21146/24149/summary.html

There are some workflows for which there are errors in the baseline:
10042.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2823567
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2823396
• DQMHistoTests: Total skipped: 170
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[kpedro88]

@jshlee while removing the standalone ME0Muon means we won't have a leak in the workflows, if the associated code will persist in CMSSW, I would prefer to have it actually fixed. Someone could reactivate it at any time.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21146/1966

[cmsbuild]

Pull request #21146 was updated. @perrotta, @cmsbuild, @kpedro88, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24392/console Started: 2017/11/13 10:04

[cmsbuild]

+1
Tested at: 31d95ff
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21146/24392/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d1d8d45
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21146/24392/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21146/24392/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21146/24392/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2771567
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2771388
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.939999999973 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[perrotta]

+1

• Already signed in GEM bugfix for issue #20772 #21146 (comment)
• Fine with the implementation of the subsequent update suggested by David

[kpedro88]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

merge