Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0.X] Fix arrow plots in geometry comparison tool #21159

Merged
merged 8 commits into from Nov 10, 2017

Conversation

ghellwig
Copy link

@ghellwig ghellwig commented Nov 3, 2017

Main focus is on resurrecting arrow plots.
Few minor fixes/changes:

  • remove remaining usage of 'eos' command
  • change default to produce only global plots which contain already all information
    • saves disk space
  • allow special characters in alignment names

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

The code-checks are being triggered in jenkins.

@ghellwig
Copy link
Author

ghellwig commented Nov 3, 2017

type bugfix

@ghellwig
Copy link
Author

ghellwig commented Nov 3, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21159/1808

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24172/console Started: 2017/11/03 21:13

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

A new Pull Request was created by @ghellwig (Gregor Mittag) for master.

It involves the following packages:

Alignment/OfflineValidation

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21159/24172/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 17 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2900266
  • DQMHistoTests: Total failures: 1623
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2898472
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@ghellwig
Copy link
Author

ghellwig commented Nov 8, 2017

@lpernie @arunhep could you please have a look?
This PR is rather trivial and mainly fixes a bug and moves a macro from the scripts to the macros folder where it actually belongs.

@arunhep
Copy link
Contributor

arunhep commented Nov 9, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@ghellwig
Copy link
Author

ghellwig commented Nov 9, 2017

@arunhep thanks!

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 46c9698 into cms-sw:master Nov 10, 2017
@ghellwig ghellwig deleted the fix-arrow-plots_10X branch December 19, 2017 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants