Better splitting and Tcrit definition for 4D vertexing (93X)

[lgray]

Backport of #20709.

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_9_3_X.

It involves the following packages:

RecoVertex/Configuration
RecoVertex/PrimaryVertexProducer

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24213/console Started: 2017/11/06 19:31

[cmsbuild]

+1
Tested at: 9e0aa4c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21190/24213/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4a685b3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21190/24213/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21190/24213/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21190/24213/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 22 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2708283
• DQMHistoTests: Total failures: 626
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2707470
• DQMHistoTests: Total skipped: 187
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 9 edm output root files, 26 DQM output files

[kpedro88]

assign upgrade

[cmsbuild]

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

[perrotta]

+1

• Identical to Better splitting and Tcrit definition for 4D vertexing #20709, merged in the master

[kpedro88]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[slava77]

@davidlange6
this was not included in 9_3_4
are we waiting for all Phase-2 PR updates to be available to merge this one?

[davidlange6]

ideally we'd have the other PR(s) needed for the hgcal re-miniaod - yes. but I just didn't include it ahead of time and didn't want to delay the build for it.

[davidlange6]

+1