Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port FastSim to pythia8 180 #2123

Merged
merged 1 commit into from
Jan 22, 2014
Merged

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Jan 22, 2014

This completes #2090 for what concerns compilation issues.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Port FastSim to pythia8 180

It involves the following packages:

FastSimulation/ParticleDecay

@cmsbuild, @Degano, @giamman, @lveldere, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ktf
Copy link
Contributor Author

ktf commented Jan 22, 2014

@mkirsano there is still a link issue, because it's apparently missing libpythia8tohepmc.so. Should it have been built?

@ktf
Copy link
Contributor Author

ktf commented Jan 22, 2014

@vciulli @bendavid

@ktf
Copy link
Contributor Author

ktf commented Jan 22, 2014

BTW, this is critical and it's a showstopper for 71X pre1. If it will not be fixed I'll revert your changes and we go with pre1 and the old pythia8.

@ktf
Copy link
Contributor Author

ktf commented Jan 22, 2014

@davidlange6

@lveldere
Copy link
Contributor

As far as I understood, this will not work out of the box, at least not properly.
I'm contacting Mojtaba, who has been working on replacing pythia 6 with 8, and update you asap.

@lveldere
Copy link
Contributor

From a private conversation with Andrea,
I understood this is nothing more than changing some paths.
Effectively, pythia6 will still be used for the decays in fastsim. Is that right?

@davidlange6
Copy link
Contributor

sorry - why is this change coupled to the pythia8 version change?

On Jan 22, 2014, at 9:54 AM, Giulio Eulisse notifications@github.com
wrote:

BTW, this is critical and it's a showstopper for 71X pre1. If it will not be fixed I'll revert your changes and we go with pre1 and the old pythia8.


Reply to this email directly or view it on GitHub.

@ktf
Copy link
Contributor Author

ktf commented Jan 22, 2014

sorry - why is this change coupled to the pythia8 version change?

Because FastSimulation/PartonDecay uses pythia8, apparently, which had
it's include files moved around and has an apparently has an incomplete
set of libraries.

@mkirsano
Copy link
Contributor

Hello,
This library should appear after the change of pythia8 version in cmsdist instead of libhepmcinterface. The library name was changed between 176 and 180.
About pythia8 includes in other parts of CMSSW I did not check. All pythia8 includes are to be changed: Pythia8/ to be added to the paths.
Should I check FastSim part or somebody else can do this?
Cheers, Mikhail


From: Giulio Eulisse [notifications@github.com]
Sent: 22 January 2014 09:52
To: cms-sw/cmssw
Cc: Mikhail Kirsanov
Subject: Re: [cmssw] Port FastSim to pythia8 180 (#2123)

@mkirsanohttps://github.com/mkirsano there is still a link issue, because it's apparently missing libpythia8tohepmc.so. Should it have been built?


Reply to this email directly or view it on GitHubhttps://github.com//pull/2123#issuecomment-33002952.

@ktf
Copy link
Contributor Author

ktf commented Jan 22, 2014

Ok, I rebuilt pythia8 and now the library is there. Not sure what has happened. I'll merge these changes and schedule a new IB, using the correct pythia8.

ktf added a commit that referenced this pull request Jan 22, 2014
Pythia8 migration -- Port FastSim to pythia8 180
@ktf ktf merged commit 3be1d3a into cms-sw:CMSSW_7_1_X Jan 22, 2014
@ktf ktf deleted the fix-pythia8-180-fastsim branch January 22, 2014 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants