Fix heap-use-after-free in L1TMuonDQMOffline::analyze #21282

davidlt · 2017-11-12T06:43:52Z

This resolves #21280

Call L1TMuonDQMOffline::getMuonGmtPairs was saving pointers to local
copies in m_MuonGmtPairs. Use previously unused gmtContainer to
extends the lifetime of objects.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

cmsbuild · 2017-11-12T06:44:12Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-11-12T06:46:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21282/1960

cmsbuild · 2017-11-12T06:46:32Z

A new Pull Request was created by @davidlt for master.

It involves the following packages:

DQMOffline/L1Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @jfernan2, @vanbesien, @mulhearn can you please review it and eventually sign? Thanks.
@kreczko, @thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2017-11-12T07:06:50Z

please test

cmsbuild · 2017-11-12T07:07:07Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24383/console Started: 2017/11/12 08:09

Dr15Jones · 2017-11-12T09:04:50Z

I don’t believe there is a need to create a std::vector<l1t::Muon> just to hold copies of l1t::Muon. Why not just get the address of the const l1t::Muon from the l1t::MuonBxCollection? That might not work if the code can’t deal with a const.

davidlt · 2017-11-12T09:14:32Z

It should work with const as we don't modify it ever (just extra phi, eta, etc). It should work l1t::MuonBxCollection is class BXVector which implements container interface. Which provide at and operator[] with const T& return values. I will check this.

cmsbuild · 2017-11-12T09:58:42Z

+1
Tested at: 96bf527
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21282/24383/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
bf43443
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21282/24383/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21282/24383/git-merge-result

cmsbuild · 2017-11-12T09:58:45Z

Comparison job queued.

cmsbuild · 2017-11-12T12:40:44Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21282/24383/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2832699
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2832520
DQMHistoTests: Total skipped: 178
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.27000000013 KiB( 23 files compared)
Checked 111 log files, 8 edm output root files, 27 DQM output files

This resolves cms-sw#21280 Call `L1TMuonDQMOffline::getMuonGmtPairs` was saving pointers to local copies in `m_MuonGmtPairs`. Use directly `edm::Handle<l1t::MuonBxCollection>` instead of making any copies to `std::vector`. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>

cmsbuild · 2017-11-12T18:31:11Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-11-12T18:35:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21282/1964

cmsbuild · 2017-11-12T18:36:07Z

Pull request #21282 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @jfernan2, @vanbesien, @mulhearn can you please check and sign again.

jfernan2 · 2017-11-12T20:23:37Z

please test

cmsbuild · 2017-11-12T20:24:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24385/console Started: 2017/11/12 21:24

cmsbuild · 2017-11-12T22:29:12Z

+1
Tested at: fe65164
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21282/24385/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d1d8d45
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21282/24385/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21282/24385/git-merge-result

cmsbuild · 2017-11-12T22:29:15Z

Comparison job queued.

cmsbuild · 2017-11-12T23:15:32Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21282/24385/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2832699
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2832520
DQMHistoTests: Total skipped: 178
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.630000000128 KiB( 23 files compared)
Checked 111 log files, 8 edm output root files, 27 DQM output files

dmitrijus · 2017-11-14T15:31:11Z

+1

davidlange6 · 2017-11-14T19:50:38Z

merge

cmsbuild added this to the CMSSW_10_0_X milestone Nov 12, 2017

cmsbuild added code-checks-pending comparison-pending dqm-pending l1-pending orp-pending pending-signatures tests-pending labels Nov 12, 2017

davidlt mentioned this pull request Nov 12, 2017

heap-use-after-free, read of 8 bytes, L1TMuonDQMOffline::analyze #21280

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 12, 2017

cmsbuild added tests-started and removed tests-pending labels Nov 12, 2017

cmsbuild added tests-approved and removed tests-started labels Nov 12, 2017

cmsbuild added comparison-available and removed comparison-pending labels Nov 12, 2017

davidlt force-pushed the fix-21280 branch from 96bf527 to fe65164 Compare November 12, 2017 18:30

cmsbuild removed the code-checks-approved label Nov 12, 2017

cmsbuild added code-checks-pending comparison-pending tests-pending and removed comparison-available tests-approved labels Nov 12, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 12, 2017

cmsbuild added tests-started and removed tests-pending labels Nov 12, 2017

cmsbuild added tests-approved and removed tests-started labels Nov 12, 2017

cmsbuild added comparison-available and removed comparison-pending labels Nov 12, 2017

cmsbuild added dqm-approved and removed dqm-pending labels Nov 14, 2017

cmsbuild added orp-approved and removed orp-pending labels Nov 14, 2017

cmsbuild merged commit a7551b2 into cms-sw:master Nov 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix heap-use-after-free in L1TMuonDQMOffline::analyze #21282

Fix heap-use-after-free in L1TMuonDQMOffline::analyze #21282

davidlt commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

jfernan2 commented Nov 12, 2017

cmsbuild commented Nov 12, 2017 •

edited

Loading

Dr15Jones commented Nov 12, 2017

davidlt commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

jfernan2 commented Nov 12, 2017

cmsbuild commented Nov 12, 2017 •

edited

Loading

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

dmitrijus commented Nov 14, 2017

davidlange6 commented Nov 14, 2017

Fix heap-use-after-free in L1TMuonDQMOffline::analyze #21282

Fix heap-use-after-free in L1TMuonDQMOffline::analyze #21282

Conversation

davidlt commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

jfernan2 commented Nov 12, 2017

cmsbuild commented Nov 12, 2017 • edited Loading

Dr15Jones commented Nov 12, 2017

davidlt commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

jfernan2 commented Nov 12, 2017

cmsbuild commented Nov 12, 2017 • edited Loading

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

cmsbuild commented Nov 12, 2017

dmitrijus commented Nov 14, 2017

davidlange6 commented Nov 14, 2017

cmsbuild commented Nov 12, 2017 •

edited

Loading

cmsbuild commented Nov 12, 2017 •

edited

Loading