-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of quality test limits #21309
Conversation
Ring 1 of the forward detector we often see mean charges under the allowed limits further into a fill on real data. Layer 1 of the barrel similarly affected in some areas.
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @lunik1 for master. It involves the following packages: DQM/SiPixelPhase1Config @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Updates to PixelPhase1 quality test limits including second commit from #20982 and subsequent adjustments to the mean charge limits in the barrel and forward detector.