Made simple_stat.h standalone #21412

Teemperor · 2017-11-21T14:25:52Z

This header is lacking header guards and it uses std::max but
doesn't include the algorithm header. This path just adds
the missing guards and the right include to make this header
work with modules.

Teemperor · 2017-11-21T14:25:57Z

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

cmsbuild · 2017-11-21T14:26:51Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-11-21T14:29:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21412/2119

cmsbuild · 2017-11-21T14:30:55Z

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

TrackingTools/DetLayers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

davidlange6 · 2017-11-21T15:42:52Z

please test

cmsbuild · 2017-11-21T15:43:28Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24574/console Started: 2017/11/21 16:43

cmsbuild · 2017-11-21T21:17:17Z

-1

Tested at: da54493

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
893188d
0707ff5
bbddd85
ed2b195
12605de
3441962
c792deb
8d25c3d
84e2869
54ee550
3468977
eeb8263
32307fd
34b0dcf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21412/24574/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21412/24574/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21412/24574/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafExamples had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
893188d
0707ff5
bbddd85
ed2b195
12605de
3441962
c792deb
8d25c3d
84e2869
54ee550
3468977
eeb8263
32307fd
34b0dcf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21412/24574/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21412/24574/git-merge-result

cmsbuild · 2017-11-21T21:17:19Z

Comparison job queued.

cmsbuild · 2017-11-21T23:26:39Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21412/24574/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3523 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2746803
DQMHistoTests: Total failures: 9398
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2737228
DQMHistoTests: Total skipped: 177
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.920000000056 KiB( 23 files compared)
Checked 111 log files, 8 edm output root files, 27 DQM output files

perrotta · 2017-11-22T15:26:00Z

TrackingTools/DetLayers/interface/simple_stat.h

@@ -1,3 +1,7 @@
+#ifndef SIMPLE_STAT_H


Please use an include guard matching the full file name subsystem_package_fileName_h

perrotta · 2017-11-27T10:31:31Z

@Teemperor : please fix the include guard as requested in #21412 (review), so that this PR can get signed

Teemperor · 2017-11-27T12:36:55Z

Done, sorry for the delay @perrotta

This header is lacking header guards and it uses std::max but doesn't include the `algorithm` header. This path just adds the missing guards and the right include to make this header work with modules.

perrotta · 2017-11-27T13:04:03Z

please test

slava77 · 2017-11-28T18:38:04Z

@cmsbuild please test

slava77 · 2017-11-28T18:38:32Z

code-checks

slava77 · 2017-11-28T18:48:26Z

@smuzaffar @mrodozov
please check the bot.
It looks like some cleanup is needed to allow automated tests to proceed.

My two last requests were recognized by the bot
https://cmssdt.cern.ch/jenkins/job/cms-bot/385466/console
https://cmssdt.cern.ch/jenkins/job/cms-bot/385467/console
But neither of them have actually triggered any dependent tests.
My guess is the same has happened when @perrotta requested tests about a day ago.

cmsbuild · 2017-11-29T07:07:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21412/2239

cmsbuild · 2017-11-29T07:07:22Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24743/console Started: 2017/11/29 13:17

cmsbuild · 2017-11-29T07:07:23Z

Pull request #21412 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

smuzaffar · 2017-11-29T08:28:31Z

@slava77 , looks like cms-bot jenkins job fail after commenting #21412 (comment) which means the code rules check job did not start and bot was waiting for it to complete. Anyway, I have updated the bot to re-trigger the code checks job when someone explicitly ask for it.

cmsbuild · 2017-11-29T13:38:26Z

+1
Tested at: e11a2ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21412/24743/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
bd23f8c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21412/24743/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21412/24743/git-merge-result

cmsbuild · 2017-11-29T13:38:28Z

Comparison job queued.

cmsbuild · 2017-11-29T14:40:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21412/24743/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2605338
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2605166
DQMHistoTests: Total skipped: 171
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.64000000013 KiB( 22 files compared)
Checked 106 log files, 8 edm output root files, 26 DQM output files

perrotta · 2017-11-29T14:55:58Z

+1

Technical
No differences in jenkins tests: extra entries in the logError plots for wf 10224 are due to extra MB files open for PU

cmsbuild · 2017-11-29T14:56:17Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2017-11-30T01:06:21Z

+1

cmsbuild added this to the CMSSW_10_0_X milestone Nov 21, 2017

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Nov 21, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 21, 2017

cmsbuild added tests-started and removed tests-pending labels Nov 21, 2017

cmsbuild added tests-rejected and removed tests-started labels Nov 21, 2017

cmsbuild added comparison-available and removed comparison-pending labels Nov 21, 2017

perrotta reviewed Nov 22, 2017

View reviewed changes

Teemperor force-pushed the StandaloneStat branch from da54493 to e11a2ab Compare November 27, 2017 12:36

Made simple_stat.h standalone

e11a2ab

This header is lacking header guards and it uses std::max but doesn't include the `algorithm` header. This path just adds the missing guards and the right include to make this header work with modules.

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 29, 2017

cmsbuild added tests-started and removed tests-pending labels Nov 29, 2017

cmsbuild added tests-approved and removed tests-started labels Nov 29, 2017

cmsbuild added comparison-available and removed comparison-pending labels Nov 29, 2017

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Nov 29, 2017

cmsbuild added orp-approved and removed orp-pending labels Nov 30, 2017

cmsbuild merged commit 1194d70 into cms-sw:master Nov 30, 2017

Teemperor deleted the StandaloneStat branch December 19, 2017 08:47

Teemperor restored the StandaloneStat branch December 19, 2017 10:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Made simple_stat.h standalone #21412

Made simple_stat.h standalone #21412

Teemperor commented Nov 21, 2017

Teemperor commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

davidlange6 commented Nov 21, 2017

cmsbuild commented Nov 21, 2017 •

edited

Loading

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

perrotta Nov 22, 2017

perrotta commented Nov 27, 2017

Teemperor commented Nov 27, 2017

perrotta commented Nov 27, 2017

slava77 commented Nov 28, 2017

slava77 commented Nov 28, 2017

slava77 commented Nov 28, 2017

cmsbuild commented Nov 29, 2017

cmsbuild commented Nov 29, 2017 •

edited

Loading

cmsbuild commented Nov 29, 2017

smuzaffar commented Nov 29, 2017

cmsbuild commented Nov 29, 2017

cmsbuild commented Nov 29, 2017

cmsbuild commented Nov 29, 2017

perrotta commented Nov 29, 2017

cmsbuild commented Nov 29, 2017

davidlange6 commented Nov 30, 2017

Made simple_stat.h standalone #21412

Made simple_stat.h standalone #21412

Conversation

Teemperor commented Nov 21, 2017

Teemperor commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

davidlange6 commented Nov 21, 2017

cmsbuild commented Nov 21, 2017 • edited Loading

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

perrotta Nov 22, 2017

Choose a reason for hiding this comment

perrotta commented Nov 27, 2017

Teemperor commented Nov 27, 2017

perrotta commented Nov 27, 2017

slava77 commented Nov 28, 2017

slava77 commented Nov 28, 2017

slava77 commented Nov 28, 2017

cmsbuild commented Nov 29, 2017

cmsbuild commented Nov 29, 2017 • edited Loading

cmsbuild commented Nov 29, 2017

smuzaffar commented Nov 29, 2017

cmsbuild commented Nov 29, 2017

cmsbuild commented Nov 29, 2017

cmsbuild commented Nov 29, 2017

perrotta commented Nov 29, 2017

cmsbuild commented Nov 29, 2017

davidlange6 commented Nov 30, 2017

cmsbuild commented Nov 21, 2017 •

edited

Loading

cmsbuild commented Nov 29, 2017 •

edited

Loading