FastTimerService: add measurement of framework overhead (94x) #21447
Conversation
fwyzard
commented
Nov 23, 2017
fwyzard
commented
- measure the time spent in the event loop, but outside any module
- keep track of the threads joining and leaving the TBB global arena
This measurement is meaningful only only for single-threaded, single-stream jobs, where it can be used as a comparison with the measurement based on the sum of the resources spent in each module.
|
backport #21446 |
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_9_4_X. It involves the following packages: HLTrigger/Timer @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
Enabled checks:
boost-use-to-string
cppcoreguidelines-no-malloc
google-build-explicit-make-pair
misc-inefficient-algorithm
misc-string-compare
misc-uniqueptr-reset-release
modernize-avoid-bind
modernize-deprecated-headers
modernize-loop-convert
modernize-make-shared
modernize-make-unique
modernize-pass-by-value
modernize-redundant-void-arg
modernize-replace-auto-ptr
modernize-shrink-to-fit
modernize-use-auto
modernize-use-bool-literals
modernize-use-emplace
modernize-use-equals-default
modernize-use-equals-delete
modernize-use-nullptr
modernize-use-override
modernize-use-transparent-functors
modernize-use-using
performance-faster-string-find
performance-for-range-copy
performance-implicit-cast-in-loop
performance-inefficient-string-concatenation
performance-type-promotion-in-math-fn
performance-unnecessary-copy-initialization
performance-unnecessary-value-param
readability-container-size-empty
readability-redundant-string-cstr
readability-static-definition-in-anonymous-namespace
readability-uniqueptr-delete-release
See http://releases.llvm.org/4.0.0/tools/clang/tools/extra/docs/clang-tidy/index.html for details.
fwyzard
force-pushed
the
FastTimerService_add_overhead_measurement_94x
branch
from
1a54f88
to
8c41d71
Compare
|
Pull request #21447 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again. |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
