Inclusion of a new tool for easier creation of comparison plots and several minor fixes #21457
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @mteroerd for master. It involves the following packages: Alignment/APEEstimation @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
|
||
|
|
||
| const LocalError& errHitWoApe = errorWithoutAPE; | ||
| const LocalError& errTrk = tsos.localError().positionError(); | ||
|
|
||
| const StatePositionAndError2 positionAndError2Hit = this->positionAndError2(lPHit, errHitApe, hit); | ||
| const StatePositionAndError2 positionAndError2HitWoApe = this->positionAndError2(lPHit, errHitWoApe, hit); | ||
| std::cout<<"errHitWoApe " <<errHitWoApe<<"errHitApe "<<errHitApe<<std::endl; | ||
| std::cout<<"errHitWoApe " <<errHitWoApe<<"errHitApe "<<errHitApe<<std::endl; |
There was a problem hiding this comment.
@mteroerd as you are touching this: you have to use the MessageLogger instead of std::cout
| } | ||
| else{ | ||
| apeX2 = std::pow(smoothFraction*std::sqrt(apeX2new) + (1-smoothFraction)*std::sqrt(apeX2old), 2); | ||
| apeY2 = std::pow(smoothFraction*std::sqrt(apeY2new) + (1-smoothFraction)*std::sqrt(apeY2old), 2); | ||
| apeY2 = std::pow(smoothFraction*std::sqrt(apeY2new) + (1-smoothFraction)*std::sqrt(apeY2old), 2); |
There was a problem hiding this comment.
@mteroerd the performance of std::pow(A, 2) is worse than A*A, i.e. I suggest to compute A and then use A*A instead of std::pow
| DefaultApeTree::sectorBuilder() | ||
| { | ||
| // Same procedure as in ApeEstimator.cc | ||
| TFile* tkTreeFile(TFile::Open((parameterSet_.getParameter<std::string>("TrackerTreeFile")).c_str())); |
There was a problem hiding this comment.
@mteroerd I believe it is recommended to use the TFileService, but @Dr15Jones might correct me.
At least, if you would use it you would have to specify this in the declaration of the Analyzer class.
There was a problem hiding this comment.
in addition, use FileInPath here.
There was a problem hiding this comment.
I can't find any documentations on TFileService or FileInPath that really explain how to correctly implement them or why they are better in this context. Can you link me to that, please?
Neither https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideEdmFileInPath nor https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideTFileService are helpful to me.
|
|
||
| process.DefaultApeTree = cms.EDAnalyzer('DefaultApeTree', | ||
| resultFile = cms.string(theOutputFile), | ||
| TrackerTreeFile = cms.string(os.environ['CMSSW_BASE'] + '/src/Alignment/TrackerAlignment/hists/TrackerTree.root'), |
There was a problem hiding this comment.
this only works if you have checked out Alignment/TrackerAlignment
There was a problem hiding this comment.
This is true. Actually, you also need to run the TrackerTreeGenerator. But this is the standard procedure when setting up the APE tool. It is also written in the guide for setting up the tool:
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideAlignmentPositionErrorEstimator#Setting_up_the_Tool
There was a problem hiding this comment.
Ok, let me propose the following for the next update:
you can conditionally run the tracker tree generator directly in this config, if the TrackerTree file does not exist (best not in a location within Alignment/TrackerAlignment to avoid the requirement of checking it out).
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
…stead of some large number
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21457/2639 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
merge |
This PR contains changes of five different categories which are divided into five different commits:
In my previous PR, I added a functionality to automate the waiting times between different iterations. This is now also added to the MC workflow. (c06ca14)
In macros/DrawIteration.C and macros/DrawPlot.C, there were several instances of 0 being used instead of nullptr. This is fixed now. Previously, using DrawPlot.C caused a Segmentation Fault when exiting the program. This is also fixed. (fc79c15)
The used EDAnalyzers in plugins/ are now multi-threading-aware. (e287898)
Instead of using a custom TTRHBuilder, now the WithAngleAndTemplate TTRHBuilder is used by default. (866f818)
This is the biggest change. A tool was added to create trees which contain custom APE values. These trees can be used for comparison plots in the APE tool. Previously, this was only possible using a workaround. The EDAnalyzer code contains code snippets from both plugins/ApeEstimator.cc and plugins/ApeEstimatorSummary.cc. (ff06640)