Cleanup in edmStreamStallGrapher #21725
Conversation
This only affects the stall grapher script and output. Fix some bugs that had insignificant effects on the pdf output file, but make the code harder to read and understand (and were adding incorrect lines to the ascii output). Add and fix some code comments. Update the command line help message. Small improvements to simplify the code itself. Small improvements to the ascii output.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21725/2604 |
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: FWCore/Concurrency @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
This only affects the stall grapher script and output.
Fix some bugs that had insignificant effects on the
pdf output file, but made the code harder to read and
understand (and were adding incorrect lines to the ascii
output). Add and fix some code comments. Update the command
line help message. Small improvements to simplify the code
itself. Small improvements to the ascii output.