-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1T offline DQM configuration to run also for cosmics runs #21768
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21768/2733 |
A new Pull Request was created by @thomreis (Thomas Reis) for master. It involves the following packages: DQMOffline/Configuration @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 An increase in histogram memory is expected since before no L1T DQM histograms were produced for cosmic runs. |
+1 |
Pull request #21768 was updated. @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please check and sign again. |
+1 Conflict has been resolved. |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
@dmitrijus @jfernan2 please sign this again. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@thomreis is the increase in memory restricted to cosmics workflows, as I understand from the sequences? |
@fabiocos yes, it should be restricted to cosmics workflows. For normal pp running the configuration was already running before and nothing has changed there. |
+1 |
Run the stage2 L1T offline DQM also for cosmics data.
The legacy behaviour should remain unchanged and no L1 DQM is produced for legacy cosmics data.