Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T offline DQM configuration to run also for cosmics runs #21768

Merged
merged 2 commits into from Jan 31, 2018

Conversation

thomreis
Copy link
Contributor

Run the stage2 L1T offline DQM also for cosmics data.
The legacy behaviour should remain unchanged and no L1 DQM is produced for legacy cosmics data.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

DQMOffline/Configuration
DQMOffline/L1Trigger

@cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks.
@threus, @kreczko, @swertz, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 21, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25251/console Started: 2017/12/21 21:08

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21768/25251/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21768/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2773742
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2773572
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 23577.26 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@thomreis
Copy link
Contributor Author

+1

An increase in histogram memory is expected since before no L1T DQM histograms were produced for cosmic runs.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Pull request #21768 was updated. @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please check and sign again.

@thomreis
Copy link
Contributor Author

+1

Conflict has been resolved.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 25, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25626/console Started: 2018/01/25 17:54

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21768/25626/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21768/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2463132
  • DQMHistoTests: Total failures: 946
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2462017
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 13218.43 KiB( 12 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@thomreis
Copy link
Contributor Author

@dmitrijus @jfernan2 please sign this again.

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@thomreis is the increase in memory restricted to cosmics workflows, as I understand from the sequences?

@thomreis
Copy link
Contributor Author

@fabiocos yes, it should be restricted to cosmics workflows. For normal pp running the configuration was already running before and nothing has changed there.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2e8d59e into cms-sw:master Jan 31, 2018
@thomreis thomreis deleted the l1t_dqm_offline_cosmics branch January 31, 2018 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants