Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NanoAOD Update (94X version of #21827) #21828

Merged
merged 32 commits into from
Jan 16, 2018
Merged

NanoAOD Update (94X version of #21827) #21828

merged 32 commits into from
Jan 16, 2018

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Jan 11, 2018

This update contains up to PR cms-nanoAOD#91

  • L1 objects update
  • ttbar categorization flags
  • updates in PDF/LHE stuff
  • genparticles status flags

same as #21827 but on 94X branch

tstreble and others added 30 commits November 21, 2017 19:05
@tstreble
Updated L1 information using dedicated MINIAOD collections
626adfe
@tstreble
Updated nanoDQM
f296a09
@tstreble
Changed precision of some TrigObj branches
6171637
@tstreble
Added l1charge for L1Muons
948a5b7
@tstreble
Updated nanoDQM
290fbc1
@tstreble
Updated nanoDQM
bab709f
@arizzi
remove trailing spaces
daf8525
@arizzi
Merge pull request #79 from tstreble/nanoAOD_L1
36b7312 
Updated L1 information using dedicated MINIAOD collections
@tstreble
Implemented self-cleaning of TrigObj
6b29aac
@tstreble
Indentation fix
b846c4c
@arizzi
Merge pull request #80 from tstreble/nanoAOD_TrigClean
5e4e9dc 
Nano aod trig clean
@gpetruc
Merge pull request #83 from gpetruc/cmssw_9_4_1
3291880 
update to CMSSW 9_4_1
@kschweiger
Added ttbar categorization
83a95c1
@kschweiger
Correct module postion in sequence for all eras assured
76c7c85
@kschweiger
Update nano_cfg.py
105f7bd
@kschweiger
Split sequence; changed era modification
8160ecc
@kschweiger
Adressed issues
48c4545
@kschweiger
Fixed bug in 80X sequence
766c158
@arizzi
Merge pull request #85 from kschweiger/nanoAOD
564c740 
ttbar categorization using GenHFHadronMatcher
@gpetruc
Catch some more formats of LHE weight headers.
5a54a6e 
Tested that it parses correctly the all following Fall17 files
  /store/mc/RunIIFall17MiniAOD/DY2JetsToLL_M-50_TuneCP5_13TeV-madgraphMLM-pythia8/MINIAODSIM/94X_mc2017_realistic_v10-v1/30000/06DF841B-D6D8-E711-8E49-02163E014665.root
  /store/mc/RunIIFall17MiniAOD/TTToSemiLeptonic_TuneCP5_PSweights_13TeV-powheg-pythia8/MINIAODSIM/94X_mc2017_realistic_v10-v1/60000/A0D71AEE-13E1-E711-B3C9-FA163E629498.root
  /store/mc/RunIIFall17MiniAOD/ST_s-channel_4f_leptonDecays_TuneCP5_13TeV-amcatnlo-pythia8/MINIAODSIM/94X_mc2017_realistic_v10-v1/70000/E8E03C84-32E1-E711-AFA8-FA163EAC4CED.root
  /store/mc/RunIIFall17MiniAOD/DYJetsToLL_M-50_TuneCP5_13TeV-amcatnloFXFX-pythia8/MINIAODSIM/94X_mc2017_realistic_v10-v1/50000/0CAD1964-6FD9-E711-97C4-FA163EE0F5F8.root
  /store/mc/RunIIFall17MiniAOD/QCD_HT700to1000_BGenFilter_TuneCP5_13TeV-madgraph-pythia8/MINIAODSIM/94X_mc2017_realistic_v10-v2/60000/0AE723BD-C0D8-E711-8606-FA163E3CBF20.root
  /store/mc/RunIIFall17MiniAOD/ST_t-channel_antitop_4f_inclusiveDecays_TuneCP5_13TeV-powhegV2-madspin-pythia8/MINIAODSIM/94X_mc2017_realistic_v10-v1/70000/C6218E8C-0FE1-E711-88EB-FA163EF3D9F3.root
  /store/mc/RunIIFall17MiniAOD/TTToHadronic_TuneCP5_13TeV-powheg-pythia8/MINIAODSIM/94X_mc2017_realistic_v10-v1/40000/6820A6D0-C9DE-E711-BF40-009C02AAB484.root

Tested also Summer16
  /store/mc/RunIISummer16MiniAODv2/DYJetsToLL_M-50_TuneCUETP8M1_13TeV-madgraphMLM-pythia8/MINIAODSIM/PUMoriond17_80X_mcRun2_asymptotic_2016_TrancheIV_v6_ext1-v2/120000/02A210D6-F5C3-E611-B570-008CFA197BD4.root
@gpetruc
one more case
f8ab969
@rappoccio
Adding other LO PDF info because it can be still used by pythia,herwi…
f2cfb2c 
…g,etc
@gpetruc
Fix docstring for scale and pdf weights
adf0431
@gpetruc
Fix cases where the central PDF weight is not included, only the vari…
88ec558 
…ations (happens in 92X MC)
@gpetruc
Fix DQM
822ee7b
@gpetruc
Merge pull request #89 from cms-nanoAOD/tag_CMSSW_9_4_2
b1c2eee 
Update to CMSSW 9_4_2
@rappoccio
Update globals_cff.py
2491820
@gpetruc
Merge pull request #87 from cms-nanoAOD/fixLHE_94X
d20c135 
Fix parsing of some LHE headers
@arizzi
Merge pull request #88 from rappoccio/fixLHE_94X_AddLOPDF
f3dbe0a 
Add LO PDF info
@l-cadamuro
gen particles flags added
96975ab
@cmsbuild cmsbuild added this to the CMSSW_9_4_X milestone Jan 11, 2018
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for CMSSW_9_4_X.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @monttj can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jan 11, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 11, 2018 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25377/console Started: 2018/01/11 15:20
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25384/console Started: 2018/01/11 16:37

@cmsbuild
Copy link
Contributor

+1
Tested at: b8a0c86
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21828/25384/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b8a0c86
f3dbe0a
d20c135
b1c2eee
564c740
766c158
3291880
5e4e9dc
36b7312
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21828/25384/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21828/25384/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21828/25384/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21828/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2717599
  • DQMHistoTests: Total failures: 107
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2717330
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 106 log files, 9 edm output root files, 25 DQM output files

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit b9efd01 into cms-sw:CMSSW_9_4_X Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-available orp-approved pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_9_4_X
Development

Successfully merging this pull request may close these issues.
9 participants
@arizzi @cmsbuild @slava77 @fabiocos @kschweiger @tstreble @gpetruc @rappoccio @l-cadamuro