Package refactoring #21890

pjurgielewicz · 2018-01-18T13:13:38Z

The code was split back into source and header maintaining the same functionality.
Histogram < enums > where changed (shortened).
Fixed flipped / outer ladder recognition in Barrel L4.

cmsbuild · 2018-01-18T13:13:58Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-01-18T13:17:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21890/2934

cmsbuild · 2018-01-18T13:17:24Z

A new Pull Request was created by @pjurgielewicz (Pawel Jurgielewicz) for master.

It involves the following packages:

DQM/SiPixelPhase1TrackClusters

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

dmitrijus · 2018-01-18T13:32:02Z

please test

cmsbuild · 2018-01-18T13:32:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25514/console Started: 2018/01/18 14:32

dmitrijus · 2018-01-18T13:33:05Z

+1

cmsbuild · 2018-01-18T13:33:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2018-01-18T15:41:04Z

-1

Tested at: afee448

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21890/25514/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2018-01-18-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 16:29:55 2018-date Thu Jan 18 16:25:58 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2018-01-18-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 16:34:20 2018-date Thu Jan 18 16:25:59 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2018-01-18-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 16:33:27 2018-date Thu Jan 18 16:26:00 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2018-01-18-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 16:36:53 2018-date Thu Jan 18 16:26:01 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2018-01-18-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 16:35:09 2018-date Thu Jan 18 16:26:11 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2018-01-18-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 16:30:46 2018-date Thu Jan 18 16:26:15 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2018-01-18-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 16:34:24 2018-date Thu Jan 18 16:26:19 2018 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2018-01-18-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 16:34:06 2018-date Thu Jan 18 16:26:20 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2018-01-18-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 16:34:16 2018-date Thu Jan 18 16:26:22 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2018-01-18-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 16:34:16 2018-date Thu Jan 18 16:26:27 2018 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2018-01-18-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 16:29:54 2018-date Thu Jan 18 16:26:32 2018 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2018-01-18-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 16:34:57 2018-date Thu Jan 18 16:26:37 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2018-01-18-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 16:29:55 2018-date Thu Jan 18 16:26:39 2018 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2018-01-18-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 16:34:57 2018-date Thu Jan 18 16:26:44 2018 s - exit: 35584

cmsbuild · 2018-01-18T15:41:07Z

Comparison job queued.

cmsbuild · 2018-01-18T16:54:33Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21890/25514/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21890/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2467599
DQMHistoTests: Total failures: 73
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2467357
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.14000000013 KiB( 22 files compared)
Checked 110 log files, 9 edm output root files, 26 DQM output files

cmsbuild · 2018-01-22T15:25:47Z

Pull request #21890 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

fioriNTU · 2018-01-22T15:33:57Z

@VinInn is it better now? Do not hesitate to suggest other improvements if you have already in mind ...

VinInn · 2018-01-22T15:46:59Z

@VinInn is it better now?

definetively.

Do not hesitate to suggest other improvements if you have already in mind ...

will have a look. Nothing obvious for the points I raised previosly

dmitrijus · 2018-01-23T16:12:57Z

+1

cmsbuild · 2018-01-23T16:13:19Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25579/console Started: 2018/01/23 17:13

cmsbuild · 2018-01-23T16:13:20Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2018-01-23T18:58:32Z

+1
Tested at: 0a0541d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21890/25579/summary.html

cmsbuild · 2018-01-23T18:58:35Z

Comparison job queued.

cmsbuild · 2018-01-23T20:29:05Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21890/25579/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21890/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2467599
DQMHistoTests: Total failures: 73
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2467357
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.19000000004 KiB( 22 files compared)
Checked 110 log files, 9 edm output root files, 26 DQM output files

fabiocos · 2018-01-27T17:43:56Z

@VinInn so do you agree to move forward with this PR?

fioriNTU · 2018-01-30T10:13:55Z

@fabiocos and @VinInn can we move ahead with this PR? We need to add quite some other changes on top of this to be included in the next production release.

VinInn · 2018-01-30T10:33:54Z

+1 on my side

fabiocos · 2018-01-30T12:17:19Z

+1

pjurgielewicz added 2 commits January 18, 2018 11:47

TrackClusters refactoring

f869215

Cleanup, changed check whether it is flipped or outer ladder

afee448

cmsbuild added this to the CMSSW_10_0_X milestone Jan 18, 2018

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jan 18, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 18, 2018

cmsbuild added tests-started and removed tests-pending labels Jan 18, 2018

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jan 18, 2018

cmsbuild added tests-rejected and removed tests-started labels Jan 18, 2018

cmsbuild removed the comparison-pending label Jan 18, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 22, 2018

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jan 23, 2018

cmsbuild added tests-started and removed tests-pending labels Jan 23, 2018

cmsbuild added tests-approved and removed tests-started labels Jan 23, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jan 23, 2018

smuzaffar modified the milestones: CMSSW_10_0_X, CMSSW_10_1_X Jan 24, 2018

cmsbuild added orp-approved and removed orp-pending labels Jan 30, 2018

cmsbuild merged commit c2db562 into cms-sw:master Jan 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Package refactoring #21890

Package refactoring #21890

pjurgielewicz commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

dmitrijus commented Jan 18, 2018

cmsbuild commented Jan 18, 2018 •

edited

Loading

dmitrijus commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

cmsbuild commented Jan 22, 2018

fioriNTU commented Jan 22, 2018

VinInn commented Jan 22, 2018 via email

dmitrijus commented Jan 23, 2018

cmsbuild commented Jan 23, 2018 •

edited

Loading

cmsbuild commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

fabiocos commented Jan 27, 2018

fioriNTU commented Jan 30, 2018

VinInn commented Jan 30, 2018

fabiocos commented Jan 30, 2018

Package refactoring #21890

Package refactoring #21890

Conversation

pjurgielewicz commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

dmitrijus commented Jan 18, 2018

cmsbuild commented Jan 18, 2018 • edited Loading

dmitrijus commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

cmsbuild commented Jan 22, 2018

fioriNTU commented Jan 22, 2018

VinInn commented Jan 22, 2018 via email

dmitrijus commented Jan 23, 2018

cmsbuild commented Jan 23, 2018 • edited Loading

cmsbuild commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

fabiocos commented Jan 27, 2018

fioriNTU commented Jan 30, 2018

VinInn commented Jan 30, 2018

fabiocos commented Jan 30, 2018

cmsbuild commented Jan 18, 2018 •

edited

Loading

cmsbuild commented Jan 23, 2018 •

edited

Loading