Make binning consistent and remove several plots in Offline DQM #21961
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21961/3045 |
|
A new Pull Request was created by @fioriNTU for master. It involves the following packages: DQM/SiPixelPhase1Common @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
@fabiocos please consider to merge also this one, it reduce a lot the content of DQm histograms |
|
@dmitrijus @jfernan2 could you please scrutinize the PR? |
|
@fioriNTU Is it understood why the Histogram memory is increased despite you are removing histograms? |
|
@jfernan2 what you say is really surprising. I am just removing plots and rebinning a single histogram (reducing the number of plots), is it possible there is a bug in the report? I am sure this specific PR should produce a net reduction in memory usage for histograms. |
|
@fioriNTU I can't tell since the test link does not exist any longer, but it says: |
|
@jfernan2 , Maybe one should retrigger the tests (to get a fresh link) and also see if it is reproducble ? |
|
please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
comparison-pending
tests-pending
tests-started
and removed
tests-pending
labels
|
It seems the memory test could be fooled by the other commits that IB added on top of this PR. The new test will clarify. Sorry for the noise. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
The increase is there because other PRs were included in the test. I will check the actual reason for this memory change. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
This PR make the binning of on track cluster charge histograms consistent and remove several plots in Offline DQM