revert stream::producer to simple producer to avoid crashes in HTXSRivetProducer

[perrozzi]

It has been observed that the use of stream::EDProducer causes a crash in the Higgs Template Cross Section Rivet producer. The change had not been captured by the validation as no dedicated relval workflow is setup.
Reverted to simple EDProducer
@dsperka @sethzenz

[cmsbuild]

The code-checks are being triggered in jenkins.

[perrozzi]

please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22025/3123

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22025/3123/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22025/3123/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22025/3155

[cmsbuild]

A new Pull Request was created by @perrozzi for master.

It involves the following packages:

GeneratorInterface/RivetInterface

@cmsbuild, @efeyazgan, @perrozzi can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrozzi]

@Dr15Jones this is the PR I was mentioning at the end of the ORP meeting.
@dsperka @sethzenz observed that the use of stream::EDProducer causes a crash in the module (can you please post the crash log?), which was working ok otherwise. what should be done in these cases?

[Dr15Jones]

Do you know for certain that Rivet does not use any global variables? If it does, then this can't be a stream module. You should probably make it a edm::one::EDProducer<> instead similar to other generators that are not thread safe.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27494/console Started: 2018/04/14 23:40

[cmsbuild]

Pull request #22025 was updated. @cmsbuild, @efeyazgan, @perrozzi can you please check and sign again.

[cmsbuild]

+1
Tested at: 2ef1aaa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22025/27494/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22025/27494/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2492535
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2492358
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 23 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[perrozzi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@perrozzi how was this validated? Resuming a past comment of mine about Rivet validation, could we setup a unit test that runs at least one analysis and compares the output to a given reference? At present we are essentially blind and relying on private checks...

[perrozzi]

@sethzenz tested it (please report)
@fabiocos you are right, we need to setup it...

[perrozzi]

@fabiocos can the PR be merged asap, as it relevant for the nanoAOD production?

[sethzenz]

@perrozzi I ran on a GluGluHToGG_M125_13TeV_amcatnloFXFX_pythia8_94X_mc2017_realistic_v10-v1 file in CMSSW_9_4_4, using GeneratorInterface/RivetInterface/test/runRivetHTXS_cfg.py as provided in the release (except for input file). The code compiled, the start and end messages were as expected, and the contents of the output file were as expected.

[fabiocos]

+1