HGCal - use calibrated energy for candidates from neutral hadrons

[felicepantaleo]

This PR fixes the energy association to a PFCandidate coming from a neutral hadron.
Previously the non-calibrated energy was used.

@ahinzmann @rovere

[cmsbuild]

The code-checks are being triggered in jenkins.

[felicepantaleo]

type bugfix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22071/3194

[cmsbuild]

A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for master.

It involves the following packages:

RecoParticleFlow/PFSimProducer

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @seemasharmafnal, @bachtis, @cbernet this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[felicepantaleo]

attaching presentation by Irene Zoi and Andreas Hinzmann showing negligible impact on jet substructure.
NeutralHadronsCalibration.pdf

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25837/console Started: 2018/02/01 14:16

[cmsbuild]

+1
Tested at: 93c9c4d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22071/25837/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22071/25837/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22071/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 972 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2465763
• DQMHistoTests: Total failures: 169
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2465425
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.8100000001 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[slava77]

assign upgrade

[cmsbuild]

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

[slava77]

+1

for #22071 93c9c4d

• the change is as described and affects only RecoParticleFlow/PFSimProducer/plugins/SimPFProducer.cc
• jenkins tests pass and comparisons with the baseline show differences only in 2023 workflows, as expected.

e.g. in 20034 there is a slight shift in neutral hadron momentum (while pf candidate eta is unchanged)

[kpedro88]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[slava77]

@fabiocos
please clarify if this can be merged soon.
Thank you.

[fabiocos]

+1