Avoid unnecessary exceptions in validation #22080
Conversation
Switch from calling AssociationMap::operator[] which can throw an exception if the key is missing to calling find() which will not throw.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22080/3209 |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: Validation/RecoEgamma @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
I found these while trying to debug a job. They were preventing me from being able to easily use |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Switch from calling AssociationMap::operator[] which can throw an
exception if the key is missing to calling find() which will not
throw.