Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding capability to write out Ptrs in JetConstituentSelector (Backport of #22092) #22093

Merged
merged 2 commits into from
Feb 15, 2018

Conversation

rappoccio
Copy link
Contributor

Backport of #22092.

Summary there:

In order to recluster AK8 jets from MINIAOD (*), we need to write out the jet constituents in a way that can be easily read out. This adds the capability to write out Ptrs and appropriate unpacking of AK8 jets. This should not affect existing workflows. Backports incoming.

(*) This is often needed for JMAR studies. There will also be an upcoming workflow for JMAR development with nanoaod.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

A new Pull Request was created by @rappoccio for CMSSW_9_4_X.

It involves the following packages:

CommonTools/RecoAlgos
DataFormats/PatCandidates

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@gouskos, @jdolen, @makortel, @abbiendi, @rovere, @ahinzmann, @gkasieczka, @jhgoh, @cbernet, @gpetruc this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

Pull request #22093 was updated. @perrotta, @cmsbuild, @monttj, @slava77 can you please check and sign again.

@perrotta
Copy link
Contributor

perrotta commented Feb 7, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25961/console Started: 2018/02/07 21:50

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22093/25961/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22093/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2718773
  • DQMHistoTests: Total failures: 109
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2718502
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 107 log files, 9 edm output root files, 26 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Feb 8, 2018

+1

@slava77 slava77 mentioned this pull request Feb 13, 2018
15 tasks
@fabiocos fabiocos changed the base branch from CMSSW_9_4_X to CMSSW_9_4_MAOD_X February 14, 2018 09:34
@fabiocos
Copy link
Contributor

Already integrated in 10_1_0_pre1

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 742139c into cms-sw:CMSSW_9_4_MAOD_X Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants