DAQ file locking compatibility fix for CC 7.4

[smorovic]

In CERN CentOS 7.4 a different behavior of file locking on NFS (v4) was observed, causing modifications of the locked file not being properly synchronized over NFS between client hosts.
Workaround, which has been proven to fix the problem in production DAQ, consists of opening another file descriptor and file stream for the same lock file within the critical section of the file locking code.

This modification is necessary to have functional HLT processing on hostswith CC 7.4

[cmsbuild]

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_10_0_X.

It involves the following packages:

EventFilter/Utilities

@mommsen, @perrotta, @cmsbuild, @emeschi, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26067/console Started: 2018/02/14 17:07

[perrotta]

@smorovic : please submit to the master branch before backporting to 10_0_X

[smorovic]

@perotta, did this as #22217.

[perrotta]

Thank you @smorovic. Please apply the code-checks there (and propagate back here) so that the tests can start on the master Srecko Morovic <notifications@github.com> ha scritto:

…

@perotta, did this as #22217. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #22215 (comment)

[perrotta]

abort test

[cmsbuild]

Jenkins tests are aborted.

[cmsbuild]

Pull request #22215 was updated. @mommsen, @perrotta, @cmsbuild, @emeschi, @slava77 can you please check and sign again.

[cmsbuild]

+1
Tested at: 412822a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22215/26067/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22215/26067/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22215/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2469361
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2469191
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.809999999801 KiB( 22 files compared)
• Checked 111 log files, 9 edm output root files, 27 DQM output files

[slava77]

+1

for #22215 412822a

• the changes are tangential to reco, affecting only EvFDaqDirector in EventFilter/Utilities (a shared package); this code is not used offline.
  • the backport is correct (diffs are identical to the version in DAQ file locking compatibility fix for CC 7.4 (master) #22217 14d9e08)
• jenkins tests pass

[emeschi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1