Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for gt update62 x #2222

Merged
5 commits merged into from Jan 30, 2014
Merged

Conversation

Martin-Grunewald
Copy link
Contributor

Fix for TSG tests after GT update, cleanup of autoCond.py.
This PR includes and superseeds PR #2182. Thus #2182 should be closed.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_6_2_X.

Fix for gt update62 x

It involves the following packages:

Configuration/AlCa
HLTrigger/Configuration

@perrotta, @cmsbuild, @diguida, @Martin-Grunewald, @nclopezo, @rcastello, @fwyzard, @Degano can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #2222 was updated. @perrotta, @cmsbuild, @diguida, @Martin-Grunewald, @nclopezo, @rcastello, @fwyzard, @Degano can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor Author

+1

Fine for TSG. @diguida, please check and sign for AlCa....

@cmsbuild
Copy link
Contributor

-1
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2222/31/summary.html

@cmsbuild
Copy link
Contributor

Pull request #2222 was updated. @perrotta, @cmsbuild, @diguida, @Martin-Grunewald, @nclopezo, @rcastello, @fwyzard, @vadler, @Degano can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor Author

I fixed the seriously outdated GT in that PAT test....

@Martin-Grunewald
Copy link
Contributor Author

+1

again

@vadler
Copy link

vadler commented Jan 29, 2014

+1

@diguida
Copy link
Contributor

diguida commented Jan 30, 2014

+1
From the AlCa side, it contains the new GT for HLT online. The cleanup in autoconf fro out-of-date HLT configurations is also nice to have.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes or unless it breaks tests. @Degano can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2222/34/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes (but tests are reportedly failing). @Degano can you please take care of it?

@Martin-Grunewald
Copy link
Contributor Author

+1

Sorry, but these errors are input file errors - problems in das or dbs or whatever script.
They have nothing to do with the content of this PR.

@ghost
Copy link

ghost commented Jan 30, 2014

I'll rerun tests now.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes (tests are also fine). @Degano can you please take care of it?

@davidlange6
Copy link
Contributor

+1

ghost pushed a commit that referenced this pull request Jan 30, 2014
@ghost ghost merged commit 4579573 into cms-sw:CMSSW_6_2_X Jan 30, 2014
@Martin-Grunewald Martin-Grunewald deleted the FixForGTUpdate62X branch February 3, 2014 05:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants