Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom fragments for SIM step are improved #2225

Merged
1 commit merged into from Jan 30, 2014
Merged

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Jan 29, 2014

It is forward port of minor fix of custom fragments - they are enabled only if g4SimHits exist. Russian roulette parameters are tuned according the most recent validation results and are not compatible with 7_0_X. No change in regular runs.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_6_2_X.

custom fragments for SIM step are improved

It involves the following packages:

SimG4Core/Application

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor Author

civanch commented Jan 29, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes or unless it breaks tests. @Degano can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes (tests are also fine). @Degano can you please take care of it?

@davidlange6
Copy link
Contributor

+1

ghost pushed a commit that referenced this pull request Jan 30, 2014
Generator -- custom fragments for SIM step are improved
@ghost ghost merged commit 33b88e9 into cms-sw:CMSSW_6_2_X Jan 30, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants