Fix after urgent message from validation campaign

[skurz]

We received messages from PdmV validation campaign for fastsim 10_1_0_pre1 vs 10_0_2 , where unfortunately an unexpected increase in the tracking efficiency got noticed. This is related to a last minute change that I did for PR20666, and unfortunetaly I introduced a bug (missing brackets).

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22311/3519

[cmsbuild]

A new Pull Request was created by @skurz for master.

It involves the following packages:

FastSimulation/SimplifiedGeometryPropagator

@cmsbuild, @ssekmen, @civanch, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ssekmen]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26249/console Started: 2018/02/22 22:35

[cmsbuild]

+1
Tested at: daf5a03
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22311/26249/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22311/26249/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 28
• DQMHistoTests: Total histograms compared: 2498056
• DQMHistoTests: Total failures: 34770
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2463110
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.959999999977 KiB( 23 files compared)
• Checked 115 log files, 9 edm output root files, 28 DQM output files

[fabiocos]

@ssekmen @civanch could you please check this fix?

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[ssekmen]

Thanks. We wanted to do one last check to ensure everything was working before signing. It seems to be the case.

[fabiocos]

@civanch @ssekmen thanks, I move forward with the integration

[fabiocos]

+1