-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx101 Try to introduce the new geometry of HGCal - only done up to EE so far #22398
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22398/3625 |
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22398/3626 |
Pull request #22398 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
please test |
Pull request #22398 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@bsunanda @kpedro88 is this code practically run in one of the tested upgrade scenarios, or are we just testing that it doesn't break DDHGcalEEAlgo (as I guess, since the v9 version is not present up to now, and I do not see associated changes in the test configurations)? As a starting point development for Phase2 it could be ok, but for my understanding I would like a confirmation |
@fabiocos the latter - just an intermediate PR to build up for further development |
@fabiocos - we cannot have a full upgrade scenario with this for a while - first to complete the G4 geometry part, then redefine DetID's, then interface with SIM step, then the reconstruction geometry and topology and finally tuning the digitization, local reco, particle flow code + validation & DQM. So it is a long path |
+1 |
Introduce the creation of wafers with the new layout and the layers for the EE part