Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx101 Try to introduce the new geometry of HGCal - only done up to EE so far #22398

Merged
merged 7 commits into from
Mar 7, 2018

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Mar 1, 2018

Introduce the creation of wafers with the new layout and the layers for the EE part

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Mar 1, 2018

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26392/console Started: 2018/03/01 01:22

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

Pull request #22398 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2018

Pull request #22398 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22398/26483/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2479021
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2478844
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.960000000072 KiB( 22 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@bsunanda
Copy link
Contributor Author

bsunanda commented Mar 5, 2018

@ianna @kpedro88 Could you approve this PR?

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 5, 2018

+1

@bsunanda
Copy link
Contributor Author

bsunanda commented Mar 6, 2018

@ianna @civanch Please approve this. It is the first step for new geometry of HGCal. I have to do this in steps because of complexity of the new design

@ianna
Copy link
Contributor

ianna commented Mar 6, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 7, 2018

@bsunanda @kpedro88 is this code practically run in one of the tested upgrade scenarios, or are we just testing that it doesn't break DDHGcalEEAlgo (as I guess, since the v9 version is not present up to now, and I do not see associated changes in the test configurations)? As a starting point development for Phase2 it could be ok, but for my understanding I would like a confirmation

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 7, 2018

@fabiocos the latter - just an intermediate PR to build up for further development

@bsunanda
Copy link
Contributor Author

bsunanda commented Mar 7, 2018

@fabiocos - we cannot have a full upgrade scenario with this for a while - first to complete the G4 geometry part, then redefine DetID's, then interface with SIM step, then the reconstruction geometry and topology and finally tuning the digitization, local reco, particle flow code + validation & DQM. So it is a long path

@bsunanda
Copy link
Contributor Author

bsunanda commented Mar 7, 2018

@fabiocos @kpedro88 This will not break any workflow currency available

@fabiocos
Copy link
Contributor

fabiocos commented Mar 7, 2018

+1

@cmsbuild cmsbuild merged commit 6ddd7ba into cms-sw:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants