Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New MVA weights file for for electron preselection #2242

Merged
merged 1 commit into from
Jan 31, 2014

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jan 30, 2014

Part 1 of splitting up #2241.

See old PR for plots.

This contains updates for e/pion MVA preselection.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_0_X.

New MVA weights file for for electron preselection

It involves the following packages:

RecoEgamma/EgammaElectronProducers
RecoEgamma/ElectronIdentification

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jan 30, 2014

sorry, I was unclear.
Only download.url is expected to change in this case.
This PR still has a chicken and egg.
I expect the following steps download.url goes to 70X -> external is updated -> IB contains has the needed file -> can ask jobs to read this needed file based on the IB as a reference

@slava77
Copy link
Contributor

slava77 commented Jan 30, 2014

@ktf maybe Giulio, who knows better how the externals are updated, can comment if it would work:
can the cmsdist pick up the download.url which is in somebody's topic branch or does it have to be in the cmssw upstream branch (70X)

@lgray
Copy link
Contributor Author

lgray commented Jan 30, 2014

@slava77 Ok, I think the PRs are now how you want.

@cmsbuild
Copy link
Contributor

Pull request #2242 was updated. @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Jan 30, 2014

+1

this is trivial
Just need an official place for the download.url file to be used to update the external
in cms-sw/cmsdist#377

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @ktf can you please take care of it?

@lgray
Copy link
Contributor Author

lgray commented Jan 31, 2014

@ktf Can this get merged in time for the 14:00 IB + updates in CMSDIST?

ktf added a commit that referenced this pull request Jan 31, 2014
Reco fixes -- New MVA weights file for for electron preselection
@ktf ktf merged commit b663278 into cms-sw:CMSSW_7_0_X Jan 31, 2014
@ktf
Copy link
Contributor

ktf commented Jan 31, 2014

Apparently I cannot write anymore /afs/cern.ch/cms/data/CMSSW/RecoEgamma/ElectronIdentification/data did something change there? @apfeiffer1

@ktf
Copy link
Contributor

ktf commented Jan 31, 2014

Ok. I think I got everything right for next IB. The file was actually
not already there...

Ciao,
Giulio

ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Advance data for RecoJets/JetProducers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants