Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synchronize HLTTrackClusterRemover to the offline version w/ SiStripClusterChargeCut #2245

Merged

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Jan 30, 2014

synchronize HLTTrackClusterRemover to the offline version w/ SiStripClusterChargeCut

the parameter which handles the switch of this cut (doStripChargeCheck) is set to FALSE as default value
=> this code update should be back-compatible

@perrotta @Martin-Grunewald @cerati @rovere

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_0_X.

synchronize HLTTrackClusterRemover to the offline version w/ SiStripClusterChargeCut

It involves the following packages:

RecoLocalTracker/SubCollectionProducers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@gpetruc, @cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

@anton-a, @thspeer, @slava77, can you sign this? It is a HLT plugin so should not affect RECO...

@slava77
Copy link
Contributor

slava77 commented Feb 4, 2014

@Degano @nclopezo
Alessandro and David: the jenkins report still doesn't have comparisons here. Why?

@slava77
Copy link
Contributor

slava77 commented Feb 5, 2014

ping

@Degano @nclopezo
Alessandro and David: the jenkins report still doesn't have comparisons here. Why?

@nclopezo
Copy link
Contributor

nclopezo commented Feb 5, 2014

Hi,

I started them again, they should be available later during the afternoon.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2014

@slava77
Copy link
Contributor

slava77 commented Feb 7, 2014

+1

based on 120d227, relying on jenkins report: no diffs in DQM (except for the SET_GLOBAL, which is sick for a different reason)

@slava77
Copy link
Contributor

slava77 commented Feb 7, 2014

Giulio,
This one was on the ORP list of requests from HLT for 70X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 7, 2014
…rgeCut@HLT

Reco -- synchronize HLTTrackClusterRemover to the offline version w/ SiStripClusterChargeCut
@ktf ktf merged commit 8c0106d into cms-sw:CMSSW_7_0_X Feb 7, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants