Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework python import tests to test each package separately #22460

Merged
merged 2 commits into from Mar 5, 2018

Conversation

davidlange6
Copy link
Contributor

@davidlange6 davidlange6 commented Mar 5, 2018

Fixes temporarily (not 100% reproducible I believe) unit test error in PhysicsTools/PythonAnalysis. We'll try to do something smarter in a followup PR.

Edit: "smarter" turned out to be straightforward, so I updated this PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

PhysicsTools/PythonAnalysis

@gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

The code-checks are being triggered in jenkins.

@davidlange6 davidlange6 changed the title remove uproot from import tests due to mismatch in llvm rework python import tests to test each package separately Mar 5, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

Pull request #22460 was updated. @gpetruc, @cmsbuild, @arizzi, @monttj can you please check and sign again.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26513/console Started: 2018/03/05 16:37

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22460/26513/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2479021
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2478844
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.18000000015 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Mar 5, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Mar 5, 2018

@davidlange6 this basically becomes a dummy test for the time being, right?

@fabiocos
Copy link
Contributor

fabiocos commented Mar 5, 2018

merge

@cmsbuild cmsbuild merged commit 842655e into cms-sw:master Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants