Validation/TrackingMCTruth : Clean up clang warnings: #22469
Conversation
Validation/TrackingMCTruth/interface/TrackingTruthValid.h:26:8: warning: 'TrackingTruthValid::beginJob' hides overloaded virtual functions [-Woverloaded-virtual]
Validation/TrackingMCTruth/interface/TrackingTruthValid.h:27:8: warning: 'endJob' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void endJob();
^
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22469/3752 |
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: Validation/TrackingMCTruth @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -23,8 +23,8 @@ class TrackingTruthValid : public DQMEDAnalyzer { | |||
| void analyze(const edm::Event&, const edm::EventSetup& ) override; | |||
|
|
|||
| void bookHistograms(DQMStore::IBooker & ibooker,const edm::Run& run, const edm::EventSetup& es) override; | |||
| void beginJob(const edm::ParameterSet& conf); | |||
| void endJob(); | |||
| void beginJob() override; | |||
There was a problem hiding this comment.
Looks like beginJob could just go away entirely since it does nothing.
gartung
changed the title
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22469/3773 |
|
Pull request #22469 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Validation/TrackingMCTruth/interface/TrackingTruthValid.h:26:8: warning: 'TrackingTruthValid::beginJob' hides overloaded virtual functions [-Woverloaded-virtual]
Validation/TrackingMCTruth/interface/TrackingTruthValid.h:27:8: warning: 'endJob' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void endJob();
^