-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the CTPPS & ECAL attributes to CondFormats/LHCInfo #22527
Added the CTPPS & ECAL attributes to CondFormats/LHCInfo #22527
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22527/3838 |
A new Pull Request was created by @coder-amey (Amey Noolkar) for master. It involves the following packages: CondFormats/RunInfo @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
The pull request has been updated with stable LHCInfo source files from CondFormats as well as CondTools packages. A sample output from the new modules is as follows: LHCInfoPopConAnalyzer: ##################################################################### %MSG lhcinfo_pop_test.db: Since: UTC (timestamp) Insertion Time Payload Object Type 2017-10-18 10:58:55 (6478203691563936160) 2018-03-09 17:21:37.693726 9cff4ed8c2ed53909764d23397e9677fe754fae2 LHCInfo LHCInfoESAnalyzer: ##################################################################### |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22527/3882 |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Hello, @franzoni, @arunhep, @lpernie and @ggovi.
@ravindkv and I have inserted the following new attributes to the LHCInfo class [UPDATED]:
From CTPPS (4):
std::string lhcState
std::string lhcComment
std::string ctppsStatus
unsigned int lumiSection
From ECAL (4):
std::vector<float> beam1VC
std::vector<float> beam2VC
std::vector<float> beam1RF
std::vector<float> beam2RF
The modules and plugins for the LHCInfo package have also been designed and implemented.
I request you to kindly scrutinize our work and provide us with your valuable suggestions so that we can improve this pull request and get it merged.
Thank you for your time.
Sincerely,
Amey & Ravindra.