-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RecoLocalTracker/SiStripClusterizer: clean up clang warnings: #22535
RecoLocalTracker/SiStripClusterizer: clean up clang warnings: #22535
Conversation
src/RecoLocalTracker/SiStripClusterizer/interface/StripClusterizerAlgorithm.h:30:91: warning: while loop has empty body [-Wempty-body] bool allBadBetween(uint16_t L, const uint16_t& R) const { while( ++L < R && bad(L) ); return L == R; } ^ src/RecoLocalTracker/SiStripClusterizer/interface/ThreeThresholdAlgorithm.h:23:8: warning: 'ThreeThresholdAlgorithm::addFed' hides overloaded virtual function [-Woverloaded-virtual] void addFed(State & state, sistrip::FEDZSChannelUnpacker & unpacker, uint16_t ipair, std::vector<SiStripCluster>& out) const { ^
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22535/3853 |
@@ -27,7 +27,7 @@ class StripClusterizerAlgorithm { | |||
float noise(const uint16_t& strip) const { return SiStripNoises::getNoise( strip, noiseRange ); } | |||
float gain(const uint16_t& strip) const { return SiStripGain::getStripGain( strip, gainRange ); } | |||
bool bad(const uint16_t& strip) const { return quality->IsStripBad( qualityRange, strip ); } | |||
bool allBadBetween(uint16_t L, const uint16_t& R) const { while( ++L < R && bad(L) ); return L == R; } | |||
bool allBadBetween(uint16_t L, const uint16_t& R) const { while( ++L < R && bad(L)) {}; { return L == R;} } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The braces around the return
do not seem to be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. Left over from when I was trying to figure out what they were doing.
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: RecoLocalTracker/SiStripClusterizer @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22535/3864 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
src/RecoLocalTracker/SiStripClusterizer/interface/StripClusterizerAlgorithm.h:30:91: warning: while loop has empty body [-Wempty-body]
bool allBadBetween(uint16_t L, const uint16_t& R) const { while( ++L < R && bad(L) ); return L == R; }
^
src/RecoLocalTracker/SiStripClusterizer/interface/ThreeThresholdAlgorithm.h:23:8: warning: 'ThreeThresholdAlgorithm::addFed' hides overloaded virtual function [-Woverloaded-virtual]
void addFed(State & state, sistrip::FEDZSChannelUnpacker & unpacker, uint16_t ipair, std::vector& out) const {
^