Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ESPrefers for v1 EGM regressions #2270

Merged
merged 1 commit into from
Feb 4, 2014

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Feb 3, 2014

Remove the ESPrefers from the EGM reconstruction for v1 regressions, as they are now in the GT.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2014

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_0_X.

Remove ESPrefers for v1 EGM regressions

It involves the following packages:

RecoEcal/EgammaClusterProducers
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaPhotonProducers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2014

@lgray
Copy link
Contributor Author

lgray commented Feb 4, 2014

@anton-a This change is trivial and I've already tested the short matrix with this patch.

Possible to +1 ?

@anton-a
Copy link

anton-a commented Feb 4, 2014

+1
4dfd774
tested in CMSSW_7_0_X_2014-02-03-0200

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 4, 2014
Reco fixes -- Remove ESPrefers for v1 EGM regressions
@ktf ktf merged commit a570fee into cms-sw:CMSSW_7_0_X Feb 4, 2014
@davidlange6
Copy link
Contributor

a belated +1from the ORP

ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants