[SiStrip-DQM] Reduce the number of bins in the Eloss histograms

[ptrstn]

Hello,

@dmitrijus , @jfernan2 , I am a new SiStrip-DQM Developer (@boudoul FYI)

I reduced the number of bin in the SiStrip Eloss histograms, since the number was previously way too high.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22856/4243

[cmsbuild]

A new Pull Request was created by @ptrstn (Peter Stein) for master.

It involves the following packages:

Validation/TrackerHits

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[boudoul]

Hello @dmitrijus , @jfernan2 , I confirm that @ptrstn is working for me (Tracker DPG) - thanks

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27332/console Started: 2018/04/05 23:39

[cmsbuild]

+1
Tested at: c7743ec
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22856/27332/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22856/27332/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2498516
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 1773
• DQMHistoTests: Total successes: 2496566
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.460000000072 KiB( 11 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[schneiml]

Hi @ptrstn, and welcome to the DQM world! The right place to make yourself a proper DQM developer is the contacts page [0] where you should be able to add yourself to the right e-groups.

Also, feel free to pass by the core-DQM meeting on tuesdays [1]. We'd like subsystem developers to come there to know what you are working on, before we get confronted with the PRs. There is not much to talk about for this PR, but since Tracker DQM tends to have quite a lot of requests, we want you there rather sooner than later.

[0] https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#Tracker_SiStrips_and_Pixels
[1] https://indico.cern.ch/event/719755/

[boudoul]

Thanks @schneiml , maybe you could then ask your colleagues to review and sign this PR ?

[schneiml]

@boudoul the usual procedure for small PRs (like this) is that they will be processed once per week, around the ORP. For things that might require discussion, please e-mail cms-dqm-coreTeam@cern.ch (github notifications won't work reliably) and probably come to the core-DQM meeting (this is sth. we want to require this year).

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

welcome optimization