Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing some unnecessary sorts in CaloJetID #2300

Merged
merged 1 commit into from
Feb 7, 2014

Conversation

rappoccio
Copy link
Contributor

Porting this PR from #2029 to 71x.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2014

A new Pull Request was created by @rappoccio for CMSSW_7_1_X.

Removing some unnecessary sorts in CaloJetID

It involves the following packages:

RecoJets/JetProducers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@yslai, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre3, CMSSW_7_1_0_pre2 Feb 5, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2014

@slava77 slava77 mentioned this pull request Feb 5, 2014
@slava77
Copy link
Contributor

slava77 commented Feb 7, 2014

@Degano @nclopezo
Alessandro and David, this is one more stuck in "still running" state

Comparison with the baseline    Still running...

@nclopezo
Copy link
Contributor

nclopezo commented Feb 7, 2014

@slava77
Hi Slava,

I started them again, you should be able to see them now.

@anton-a
Copy link

anton-a commented Feb 7, 2014

+1
based on code inspection (80c1e65) and jenkins DQM results. No regression observed.
Suggest to remove the commented out lines in future revisions.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 7, 2014
Reco -- Removing some unnecessary sorts in CaloJetID
@ktf ktf merged commit ef9fd99 into cms-sw:CMSSW_7_1_X Feb 7, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@rappoccio rappoccio deleted the rappoccio_CaloJetIDOpt branch November 3, 2014 21:11
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants