Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating MssmHbb and Trigger Btagging Monitor with DeepCSV algo #23132

Merged
merged 5 commits into from Jun 5, 2018
Merged

Updating MssmHbb and Trigger Btagging Monitor with DeepCSV algo #23132

merged 5 commits into from Jun 5, 2018

Conversation

antoniovagnerini
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

A new Pull Request was created by @antoniovagnerini for master.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @drkovalskyi, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented May 3, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27777/console Started: 2018/05/03 19:44

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23132/27777/summary.html

Comparison Summary:

  • You potentially added 2658 lines to the logs
  • Reco comparison results: 34 differences found in the comparisons
  • DQMHistoTests: Total files compared: 30
  • DQMHistoTests: Total histograms compared: 2721257
  • DQMHistoTests: Total failures: 439
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2720635
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -3.432 KiB( 29 files compared)
  • DQMHistoSizes: changed ( 136.731,... ): -0.312 KiB HLT/Higgs
  • Checked 124 log files, 14 edm output root files, 30 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23132/28351/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902471
  • DQMHistoTests: Total failures: 68
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2902213
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Jun 2, 2018

please test

log files now should be clean, anyway the problems looks solved

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28395/console Started: 2018/06/02 18:29

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23132/28395/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902471
  • DQMHistoTests: Total failures: 68
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2902213
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Jun 3, 2018

unhold

the problem that triggered the "hold" action seems to be solved. @jfernan2 @dmitrijus could you please check and sign this in case?

@cmsbuild cmsbuild removed the hold label Jun 3, 2018
@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jun 5, 2018

+1

@cmsbuild cmsbuild merged commit 44d2e11 into cms-sw:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants