-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore MemoryCheck in LogError skims #23152
Conversation
A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_10_1_X. It involves the following packages: FWCore/Modules @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@cmsbuild please test |
The tests are being triggered in jenkins. |
This also needs to go into 10_2 |
Comparison job queued. |
I'm not planning on signing this until there is a pull request to master |
Comparison is ready Comparison Summary:
|
backport of #23153 |
Pull request #23152 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #23153
LogError skim is currently flooded by the MemoryCheck and less significantly by HLTObjectsMonitor LogWarning categories.
This PR should skip both during LogError RAW-RECO skimming and skip MemoryCheck for the LogErrorMonitor skim .