Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore MemoryCheck in LogError skims #23152

Merged
merged 2 commits into from
May 9, 2018
Merged

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented May 4, 2018

backport of #23153

LogError skim is currently flooded by the MemoryCheck and less significantly by HLTObjectsMonitor LogWarning categories.
This PR should skip both during LogError RAW-RECO skimming and skip MemoryCheck for the LogErrorMonitor skim .

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_10_1_X.

It involves the following packages:

FWCore/Modules

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented May 4, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27812/console Started: 2018/05/04 20:32

@Dr15Jones
Copy link
Contributor

This also needs to go into 10_2

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

Comparison job queued.

@Dr15Jones
Copy link
Contributor

I'm not planning on signing this until there is a pull request to master

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23152/27812/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2507116
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2506939
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.815 KiB( 28 files compared)
  • DQMHistoSizes: changed ( 25202.0 ): 0.008 KiB HLT/EventInfo
  • DQMHistoSizes: changed ( 25202.0 ): 0.007 KiB SiStrip/EventInfo
  • DQMHistoSizes: changed ( 25202.0 ): 0.007 KiB L1TEMU/EventInfo
  • DQMHistoSizes: changed ( 25202.0,... ): 0.007 KiB Pixel/EventInfo
  • DQMHistoSizes: changed ( 25202.0 ): 0.007 KiB RPC/EventInfo
  • DQMHistoSizes: changed ( 25202.0,... ): 0.005 KiB L1T/EventInfo
  • DQMHistoSizes: changed ( 25202.0,... ): 0.005 KiB Muons/EventInfo
  • DQMHistoSizes: changed ( 25202.0,... ): 0.005 KiB DT/EventInfo
  • DQMHistoSizes: changed ( 25202.0,... ): 0.004 KiB Tracking/EventInfo
  • DQMHistoSizes: changed ( 25202.0,... ): 0.004 KiB Ecal/EventInfo
  • DQMHistoSizes: changed ( 25202.0 ): ...
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@slava77
Copy link
Contributor Author

slava77 commented May 4, 2018

backport of #23153

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2018

Pull request #23152 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again.

@slava77 slava77 changed the title ignore non-reco categories from LogError ignore MemoryCheck in LogError skims May 7, 2018
@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27841/console Started: 2018/05/08 05:30

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23152/27841/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2508502
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2508325
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented May 9, 2018

+1

@cmsbuild cmsbuild merged commit 9d292d4 into cms-sw:CMSSW_10_1_X May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants