Run2-hcx177 Small bug fixes in view of Phase2 HCAL

[bsunanda]

Changes in view of Phase2 sceanrio with post TDR HGCal

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23342/4844

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HcalCommonData

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28202/console Started: 2018/05/25 19:39

[cmsbuild]

+1
Tested at: cbd3437
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23342/28202/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23342/28202/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2901706
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2901515
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[fabiocos]

@bsunanda sorry, the title mentions Phase2, but aren't these files used also for the 2018 geometry?
No effect is observed in the tests, but is any expected? Could you please comment on the expected impact of this PR (and possibly update the initial description)?

[bsunanda]

The xml files are for Phase2 and the code has a bug fix. This fix is not going to affect any of the xml files but it was logically wrong earlier

[bsunanda]

@ianna @civanch Please approve this PR

[bsunanda]

@ianna @civanch Please approve this PR

[fabiocos]

@ianna @civanch could you please check and sign in case?

[bsunanda]

@ianna @civanch @fabiocos Please approve this at the earliest

[fabiocos]

@bsunanda the title of the PR mentions PhaseII, but this code touches the HCAL geometry as far as I can see. Could you please clarify?

[ianna]

@fabiocos - most of the tests we have in IBs are taking geometry from DB. @bsunanda - please, let us know if these changes affect non Phase 2 Hcal?

[bsunanda]

@ianna @fabiocos the changes will affect Phase2 geometry only (the xml changes). the change in the code is a simple bug fix but the interpretation of the xml files are not affected because the condition where such error would have occurred is not present

[bsunanda]

@ianna @fabiocos please approve this pr because it is needed for the scenario with the new hgcal geometry

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

changes to configurations refer to post-2018 scenarios, the change in code does not affect old situations (according to @bsunanda explanation)